-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test jlpm versions, test with nodejs lts, bump build number #110
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
recipe/meta.yaml
Outdated
@@ -30,12 +30,13 @@ requirements: | |||
- subprocess32 # [py2k] | |||
test: | |||
requires: | |||
- nodejs | |||
- nodejs >=8,<9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should be nodejs >=8,<10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(that is, if you want to catch valid node versions. If you explicitly want LTS, never mind.)
(that is, if you want to catch valid node versions. If you explicitly
want LTS, never mind.)
Yeah I think we only want to test with node LTS releases. 9 is already EOL.
https://github.com/nodejs/Release/blob/master/README.md#end-of-life-releases
Once yarn is good with 10, we'll want to support that, of course, as it
will get us into 2020.
… |
Cool!
…On Fri, Oct 5, 2018 at 12:45 PM Jason Grout ***@***.***> wrote:
Closed #110 <#110>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACxRLUpGchTzWPPVGhrBL_CO3YePCvMks5uh4zBgaJpZM4UUDBh>
.
|
Checklist
0
(if the version changed)conda-smithy
While we are trying to look into node 10, this will take a look at what we've got today...