test jlpm versions, test with nodejs lts, bump build number #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
jasongrout
reviewed
Jul 19, 2018
recipe/meta.yaml
Outdated
| @@ -30,12 +30,13 @@ requirements: | |||
| - subprocess32 # [py2k] | |||
| test: | |||
| requires: | |||
| - nodejs | |||
| - nodejs >=8,<9 | |||
There was a problem hiding this comment.
Probably should be nodejs >=8,<10
There was a problem hiding this comment.
(that is, if you want to catch valid node versions. If you explicitly want LTS, never mind.)
|
(that is, if you want to catch valid node versions. If you explicitly
want LTS, never mind.)
Yeah I think we only want to test with node LTS releases. 9 is already EOL.
https://github.com/nodejs/Release/blob/master/README.md#end-of-life-releases
Once yarn is good with 10, we'll want to support that, of course, as it
will get us into 2020.
… |
jasongrout
added a commit
to jasongrout/jupyterlab-feedstock
that referenced
this pull request
Oct 5, 2018
|
Cool!
…On Fri, Oct 5, 2018 at 12:45 PM Jason Grout ***@***.***> wrote:
Closed #110 <#110>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACxRLUpGchTzWPPVGhrBL_CO3YePCvMks5uh4zBgaJpZM4UUDBh>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithyWhile we are trying to look into node 10, this will take a look at what we've got today...