Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] gensim v3.6.0 #14

Closed

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes and instructions for merging this PR:

  1. Please check that the dependencies have not changed.
  2. Please merge the PR only after the tests have passed.
  3. Feel free to push to the bot's branch to update this PR if needed.
  4. The bot will almost always only open one PR per version.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The build section contained an unexpected subsection name. build is not a valid subsection name.
  • The build section contained an unexpected subsection name. host is not a valid subsection name.
  • The build section contained an unexpected subsection name. run is not a valid subsection name.

For recipe:

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@menshikh-iv
Copy link
Member

@souravsingh we added C++ code to gensim with c++11 standard any ideas how to fix build?

@menshikh-iv
Copy link
Member

menshikh-iv commented Sep 21, 2018

@jakirkham can you give us an advice please, what we should do: we add more Cython to gensim (but this part translated to cpp using c++11 standard, earlier it was only pure-C) and now this can't be built for conda? I think we should do something with compilers, but I'm not familiar with forge ecosystem.

@souravsingh
Copy link
Contributor

@menshikh-iv I think we would need to do something similar to what shogun does- https://github.com/conda-forge/shogun-feedstock/blob/master/recipe/meta.yaml#L73

I believe we should wait for a comment from either @isuruf or @jakirkham before we can change anythng.

@isuruf
Copy link
Member

isuruf commented Sep 21, 2018

@conda-forge-admin, please rerender.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render.

@jakirkham
Copy link
Member

@conda-forge-admin, please re-render.

(Third time is the charm 🍀)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@jakirkham
Copy link
Member

can you give us an advice please, what we should do: we add more Cython to gensim (but this part translated to cpp using c++11 standard, earlier it was only pure-C) and now this can't be built for conda?

So looks like @isuruf already helped out on getting this feedstock using the new compiler syntax, which will help with a variety of things. The feedstock is also now re-rendered to take advantage of this functionality. The compilers available should already support C++11 (with the exception of Python 2.7 on Windows, which has too old of a compiler). We may need to add an explicit C++ flag to use C++11 support with the compilers (i.e. -std=c++11). On Windows IIRC they skipped straight to C++14, so the flag used will differ between the two platforms (i.e. -std=c++14). HTH

@menshikh-iv
Copy link
Member

menshikh-iv commented Sep 22, 2018

Thanks @isuruf @jakirkham for help

We already have some compiler options (for Linux & OSX)
https://github.com/RaRe-Technologies/gensim/blob/676372a106d093ea2f47d246585e1b386240192f/setup.py#L265-L272

I see than now all builds failed, both OS with same error (strange, because standrat wheel for windows builded correctly, see https://ci.appveyor.com/project/piskvorky/gensim-wheels/build/1.0.112, same for linux)

[00:11:20] ./gensim/models/word2vec_corpusfile.cpp(591): fatal error C1083: Cannot open include file: 'fast_line_sentence.h': No such file or directory
[00:11:20] command 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\BIN\\amd64\\cl.exe' failed with exit status 2

though this file exist in distribution https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/models/fast_line_sentence.h (UPD this file missing in .tar.gz, maybe when I add it, the problem will be resolved) fixed piskvorky/gensim#2194

So, questions:

  • Should I add another compilation options? No, it works well with already existing options
  • How can I build without release (i.e. PyPI)? I'm not sure that adding .h the file will fix all issues and want to be sure that it works before official release? Found in documentation and already use it
  • How to add OSX to build (since we have started setting up conda-forge builds, I'm pretty sure that I'll have an issue with it here, see Setup build for MacOSX  #11 & osx build with unittest #12 )?
  • How to add python3.7?

@menshikh-iv
Copy link
Member

@conda-forge-admin please re-render.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@souravsingh
Copy link
Contributor

@menshikh-iv The tests for package now pass. Do you want me to merge the PR right now?

@menshikh-iv menshikh-iv changed the title gensim v3.6.0 [DNM] gensim v3.6.0 Sep 22, 2018
@menshikh-iv
Copy link
Member

menshikh-iv commented Sep 22, 2018

@souravsingh no, I just check a hypothesis than an issue in missing files. I'll use this PR as the place for improving current configuration (I want to add py37 & OSX builds, see my comment above). In parallel - apply needed changes for Gensim and in next gensim release I'll apply all needed changes & merge (current PR or new one with all changes)

@menshikh-iv
Copy link
Member

@isuruf @jakirkham I'll be really appreciate if you'll help me with this things

@menshikh-iv menshikh-iv removed their request for review September 24, 2018 14:33
@jakirkham
Copy link
Member

Add OSX build

I'm sorry @menshikh-iv. I don't really have bandwidth for this unfortunately. 😞

Add python3.7

This will happen eventually as we are doing a rebuild of the whole stack. It will take a bit as there are many simultaneous rebuilds being combined into one. ( conda-forge/conda-forge.github.io#649 )

@souravsingh
Copy link
Contributor

souravsingh commented Sep 24, 2018

@menshikh-iv Rebuild for Python 3.7 arrived for one of the feedstock I maintain- conda-forge/validictory-feedstock#7

I would say support for Python 3.7 would arrive soonish.

@menshikh-iv
Copy link
Member

@souravsingh great, I'll wait for it

@menshikh-iv
Copy link
Member

@jakirkham no problem

@menshikh-iv menshikh-iv mentioned this pull request Oct 5, 2018
@menshikh-iv
Copy link
Member

continued in #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants