Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activate.sh: enable bash completion #1041

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Jan 6, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@rouault
Copy link
Contributor Author

rouault commented Jan 6, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 6, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12816665949. Examine the logs at this URL for more detail.

@rouault rouault closed this Jan 7, 2025
@rouault rouault reopened this Jan 7, 2025
@rouault
Copy link
Contributor Author

rouault commented Jan 7, 2025

osx-arm64 failure is unrelated (is there a way to restart jobs. I don't seem to have the rights)

besides that, is sourcing the GDAL bash config script in activate.sh the appropriate thing to do ? At least it does the job for me. I'd have wished that some generic Conda environment activation magic would do that automatically.

@akrherz
Copy link
Contributor

akrherz commented Jan 7, 2025

@rouault Do you see a re-run here ?

@rouault
Copy link
Contributor Author

rouault commented Jan 7, 2025

@rouault Do you see a re-run here ?

Thanks! I do. I have missed that initially (I tried at a later stage in https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1137370&view=results and it asked for Azure credentials)

@rouault
Copy link
Contributor Author

rouault commented Jan 16, 2025

Any feedback from fellow maintainers on the soundness of the change ?

@akrherz
Copy link
Contributor

akrherz commented Jan 16, 2025

Any feedback from fellow maintainers on the soundness of the change ?

Seems fine to me, but I have never looked into how this all is supposed to work within conda forge.

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

recipe/meta.yaml Outdated Show resolved Hide resolved
@rouault
Copy link
Contributor Author

rouault commented Jan 16, 2025

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12816675806. Examine the logs at this URL for more detail.

@xylar xylar added the automerge Merge the PR when CI passes label Jan 16, 2025
@rouault
Copy link
Contributor Author

rouault commented Jan 16, 2025

Ok, so we have a OSX Arm64 failure, and that's exactly the same one I've struggled today on GDAL CI too:

WARNING: Partially parsed some '.tbd' files in sysroot /Applications/Xcode_15.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk, pretending .tbds are their install-names
Adding support to 'conda-build' for parsing these in 'liefldd.py' would be easy and useful:
['System/Library/PrivateFrameworks/SiriFoundation.framework/SiriFoundation.tbd', 'System/Library/PrivateFrameworks/CrashReporterSupport.framework/Versions/A/CrashReporterSupport.tbd']...
Traceback (most recent call last):
  File "/Users/runner/miniforge3/bin/conda-build", line 11, in <module>
    sys.exit(execute())
             ^^^^^^^^^
  File "/Users/runner/miniforge3/lib/python3.12/site-packages/conda_build/cli/main_build.py", line 622, in execute
    api.build(
  File "/Users/runner/miniforge3/lib/python3.12/site-packages/conda_build/api.py", line 211, in build
    return build_tree(
           ^^^^^^^^^^^
  File "/Users/runner/miniforge3/lib/python3.12/site-packages/conda_build/build.py", line 3656, in build_tree
    packages_from_this = build(
                         ^^^^^^
  File "/Users/runner/miniforge3/lib/python3.12/site-packages/conda_build/os_utils/liefldd.py", line 210, in get_rpathy_thing_raw_partial
    if command.command == lief.MachO.LOAD_COMMAND_TYPES.RPATH
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'lief._lief.MachO' has no attribute 'LOAD_COMMAND_TYPES'

@xylar
Copy link
Contributor

xylar commented Jan 16, 2025

@rouault, this is conda/conda-build#5594. Nothing to do with us.

@xylar xylar removed the automerge Merge the PR when CI passes label Jan 16, 2025
@akrherz akrherz added the automerge Merge the PR when CI passes label Jan 17, 2025
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 17, 2025

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed
  • rerender called: passed

Thus the PR was passing and merged! Have a great day!

@xylar
Copy link
Contributor

xylar commented Jan 17, 2025

The issue seems to be fixed. Hopefully the tests will pass this time and the merge will go through.

@conda-forge-admin conda-forge-admin merged commit 4d0b491 into conda-forge:main Jan 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants