-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activate.sh: enable bash completion #1041
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12816665949. Examine the logs at this URL for more detail. |
3a30f8b
to
77e3d14
Compare
osx-arm64 failure is unrelated (is there a way to restart jobs. I don't seem to have the rights) besides that, is sourcing the GDAL bash config script in activate.sh the appropriate thing to do ? At least it does the job for me. I'd have wished that some generic Conda environment activation magic would do that automatically. |
Thanks! I do. I have missed that initially (I tried at a later stage in https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1137370&view=results and it asked for Azure credentials) |
Any feedback from fellow maintainers on the soundness of the change ? |
Seems fine to me, but I have never looked into how this all is supposed to work within conda forge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
c56ffed
to
1aafe19
Compare
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12816675806. Examine the logs at this URL for more detail. |
Ok, so we have a OSX Arm64 failure, and that's exactly the same one I've struggled today on GDAL CI too:
|
@rouault, this is conda/conda-build#5594. Nothing to do with us. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
The issue seems to be fixed. Hopefully the tests will pass this time and the merge will go through. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)