Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #18

regro-cf-autotick-bot · 2018-10-17T07:31:29Z

It is likely this feedstock needs to be rebuilt.
Notes and instructions for merging this PR:

Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:
simbody
And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

_{This PR was created by the cf-regro-autotick-bot.

The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.

Finally, feel free to drop us a line if there are any issues!}

conda-forge-linter · 2018-10-17T07:40:56Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham · 2018-10-21T01:11:39Z

Guess this needs some kind of cdt package. @mingwandroid, would you be able to advise here?

mingwandroid · 2018-10-21T15:47:22Z

Yeah but just copy the changes from our fork or do you want me to do that?

https://github.com/AnacondaRecipes/freeglut-feedstock/blob/master/recipe/meta.yaml#L24

conda-forge-linter · 2018-11-02T18:45:36Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [27]

conda-forge-linter · 2018-11-02T18:50:22Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

shadowwalkersb · 2018-11-02T19:38:43Z

@mingwandroid , had to add libxxf86vm in addition to the cdt packages in your fork. Is that OK?

mingwandroid · 2018-11-02T20:41:40Z

Sure thing. If it's needed then it's needed!

shadowwalkersb · 2018-11-02T20:46:39Z

Thanks, @mingwandroid !

@jakirkham , could you take a quick look and merge if looks OK? Not sure if it is appropriate for me to merge.

jakirkham · 2018-11-02T21:03:31Z

I'm not sure if we should be using CDTs for X11 packages or conda-forge ones. Will defer to others.

cc @conda-forge/core @pkgw

mingwandroid · 2018-11-02T21:09:06Z

@pkgw informs me that the x11 stack doesn't touch GL at all, so I'm not sure you have a choice. Even if you did provide Mesa it would be software only which is not good at all. I think CDTs for gl is best.

mingwandroid · 2018-11-02T21:10:27Z

It may be possible to make a Mesa that looks to the system GL then link that to X11, but I don't know how much effort that'd be or if it's even possible.

hmaarrfk · 2018-12-11T07:55:16Z

Sorry for jumping on here, but if I'm packaging GLFW, a similar library that is used by glumpy, it seems that I should be using cdt packages instead of conda-forge ones?

https://github.com/ramonaoptics/glfw-feedstock/blob/master/recipe/meta.yaml

scopatz · 2018-12-11T12:12:01Z

Nope, you should always prefer conda-forge packages to CDT

jakirkham · 2018-12-30T09:18:17Z

recipe/meta.yaml

+    - {{ cdt('libxfixes-devel') }}       # [linux]
+    - {{ cdt('mesa-libgl-devel') }}      # [linux]
+    - {{ cdt('xorg-x11-proto-devel') }}  # [linux]
+    - {{ cdt('libxxf86vm-devel') }}      # [linux]


@pkgw, can you please look over this list and check to see if these CDTs are still needed or if there are conda-forge X11 packages they can be replaced with?

Untested, but:

libxfixes-devel → xorg-libxfixes

xorg-x11-proto-devel → xorg-xproto

Thanks for the updates. We may need to make similar changes to qt.

ref: https://github.com/conda-forge/qt-feedstock/blob/a16262b187248038b8d2f14a9cb0416d107448a6/recipe/meta.yaml#L39

It would also be good to come up with a list of acceptable X11 CDTs to use and add them to the docs with the rest coming from conda-forge X11 packages.

Seems libxxf86vm-devel was making use of xorg-x11-proto-devel. So dropping that requirement caused the new Linux compiler build to fail. Have reverted that change, which fixes the issue.

Using xorg-libxfixes worked fine. So that change has been made.

A similar change will be needed for Qt as well. Have raised issue ( conda-forge/qt-feedstock#85 ) about this.

Yeah, we really need better documentation on it :/ I'm so confused about when to use what.

jakirkham · 2018-12-30T09:28:47Z

@conda-forge-admin, please re-render.

These have either been added to the base image, included in the requirements, or added as CDTs. Regardless of the reason, they are no longer needed from `yum`. So go ahead and drop these `yum` dependencies and `yum_requirements.txt` altogether.

Now that the `yum` requirements have been dropped, re-render to update associated build files with this change.

This reverts commit 9f23561. It seems using the `conda-forge` package for `xorg-xproto` doesn't quite work as it appears it causes the CDT `libxxf86vm-devel` to miss a few headers it expects to find. As a result, the build fails with the new compilers. Reverting to the CDT in this case should fix the issue. ref: https://circleci.com/gh/conda-forge/freeglut-feedstock/97

regro-cf-autotick-bot added 2 commits October 17, 2018 07:31

bump build number

642b580

MNT: Re-rendered with conda-smithy 3.1.12 and pinning 2018.10.16

1fa560e

add cdt packages

9d1afb6

lint selector spaces

603bdeb

shadowwalkersb added 2 commits November 2, 2018 14:07

add cdt package: libxcomposite-devel

a906ebb

replace cdt: libxxf86vm

54eabcc

jakirkham added 3 commits December 30, 2018 04:09

Use conda-forge's libxcb instead of the CDT

bed786b

Use conda-forge's xorg-libxi instead of the CDT

46e91e1

Use conda-forge's xorg-libx11 instead of the CDT

9c51642

jakirkham force-pushed the rebuild branch from 7523c0c to 9c51642 Compare December 30, 2018 09:13

jakirkham added 2 commits December 30, 2018 04:13

Use conda-forge's xorg-libxau instead of the CDT

36e0c13

Use conda-forge's xorg-libxext instead of a CDT

22e53ba

jakirkham reviewed Dec 30, 2018

View reviewed changes

conda-forge-admin and others added 3 commits December 30, 2018 09:29

MNT: Re-rendered with conda-smithy 3.2.2 and pinning 2018.12.28

5b08f38

Remove yum_requirements.txt

e4424ca

These have either been added to the base image, included in the requirements, or added as CDTs. Regardless of the reason, they are no longer needed from `yum`. So go ahead and drop these `yum` dependencies and `yum_requirements.txt` altogether.

MNT: Re-rendered with conda-smithy 3.2.2 and pinning 2018.12.28

45b7687

Now that the `yum` requirements have been dropped, re-render to update associated build files with this change.

jakirkham added 3 commits December 30, 2018 13:32

Switch to xorg-libxfixes instead of the CDT

68a524f

Switch to xorg-xproto instead of the CDT

9f23561

jakirkham mentioned this pull request Dec 30, 2018

Should this be using CDT Dependencies? conda-forge/glew-feedstock#9

Closed

jakirkham merged commit dec740f into conda-forge:master Dec 31, 2018

regro-cf-autotick-bot deleted the rebuild branch December 31, 2018 05:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #18

Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #18

regro-cf-autotick-bot commented Oct 17, 2018

conda-forge-linter commented Oct 17, 2018

jakirkham commented Oct 21, 2018

mingwandroid commented Oct 21, 2018

conda-forge-linter commented Nov 2, 2018

conda-forge-linter commented Nov 2, 2018

shadowwalkersb commented Nov 2, 2018

mingwandroid commented Nov 2, 2018

shadowwalkersb commented Nov 2, 2018

jakirkham commented Nov 2, 2018

mingwandroid commented Nov 2, 2018

mingwandroid commented Nov 2, 2018

hmaarrfk commented Dec 11, 2018 •

edited

Loading

scopatz commented Dec 11, 2018

jakirkham Dec 30, 2018

pkgw Dec 30, 2018

jakirkham Dec 30, 2018

jakirkham Dec 30, 2018

jakirkham Dec 30, 2018 •

edited

Loading

hmaarrfk Dec 30, 2018

jakirkham commented Dec 30, 2018

Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #18

Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 #18

Conversation

regro-cf-autotick-bot commented Oct 17, 2018

conda-forge-linter commented Oct 17, 2018

jakirkham commented Oct 21, 2018

mingwandroid commented Oct 21, 2018

conda-forge-linter commented Nov 2, 2018

conda-forge-linter commented Nov 2, 2018

shadowwalkersb commented Nov 2, 2018

mingwandroid commented Nov 2, 2018

shadowwalkersb commented Nov 2, 2018

jakirkham commented Nov 2, 2018

mingwandroid commented Nov 2, 2018

mingwandroid commented Nov 2, 2018

hmaarrfk commented Dec 11, 2018 • edited Loading

scopatz commented Dec 11, 2018

jakirkham Dec 30, 2018

Choose a reason for hiding this comment

pkgw Dec 30, 2018

Choose a reason for hiding this comment

jakirkham Dec 30, 2018

Choose a reason for hiding this comment

jakirkham Dec 30, 2018

Choose a reason for hiding this comment

jakirkham Dec 30, 2018 • edited Loading

Choose a reason for hiding this comment

hmaarrfk Dec 30, 2018

Choose a reason for hiding this comment

jakirkham commented Dec 30, 2018

hmaarrfk commented Dec 11, 2018 •

edited

Loading

jakirkham Dec 30, 2018 •

edited

Loading