Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update numpy #22

Merged
merged 2 commits into from
Oct 9, 2022
Merged

update numpy #22

merged 2 commits into from
Oct 9, 2022

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Oct 8, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • requirements: run: numpy >= 1.20 should not contain a space between relational operator and the version, i.e. numpy >=1.20

recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/flox-feedstock/actions/runs/3211269520.

@dcherian
Copy link
Contributor Author

dcherian commented Oct 8, 2022

@ocefpaf I forgot to bump numpy min version on the latest release. Is this enough or do we have explicitly remove the old builds somehow?

@ocefpaf
Copy link
Member

ocefpaf commented Oct 8, 2022

For micromamba, mamba, and conda with libmamba this is enough b/c the higher build numbers are preferred. For vanilla conda one can get the lower build number with the bad pin depending on the solver's solution.

You can mark it as broken or send a repodata patch to fix it. The former is easier though.

@dcherian
Copy link
Contributor Author

dcherian commented Oct 9, 2022

mark it as broken

OK let's do this. Shall I follow the first half of the instructions in https://conda-forge.org/docs/maintainer/updating_pkgs.html#removing-broken-packages? (since the metadata is broken not the package itself)

@dcherian dcherian merged commit c094aed into conda-forge:main Oct 9, 2022
@dcherian dcherian deleted the bump-numpy branch October 9, 2022 02:06
@ocefpaf
Copy link
Member

ocefpaf commented Oct 9, 2022

Shall I follow the first half of the instructions in https://conda-forge.org/docs/maintainer/updating_pkgs.html#removing-broken-packages? (since the metadata is broken not the package itself)

Yep. That should do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants