Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CRB repo on alma9, PowerTools on alma8 #299

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Dec 12, 2024

With the switch to alma8 & alma9, some of our CDTs are now split across separate repos. In particular, we need PowerTools on alma8, resp. CRB on alma9 (which is essentially the same thing but got renamed). See for example conda-forge/cdt-builds@e118347

As an example, the following failed:

+ /usr/bin/sudo -n yum install -y wget m4 help2man patch gcc-gfortran gcc-c++ rsync sed findutils make file strace
AlmaLinux 9 - AppStream                          30 MB/s | 9.2 MB     00:00    
AlmaLinux 9 - BaseOS                            3.2 MB/s | 4.5 MB     00:01    
AlmaLinux 9 - Extras                             86 kB/s |  13 kB     00:00    
No match for argument: help2man

That package is available under CRB on alma9, so enable this repo.

otherwise, the second `:` (and everything that follows) wrongly gets
interpreted as payload for the first append command
This reverts commit 231bb36.
@h-vetinari h-vetinari marked this pull request as ready for review December 12, 2024 11:44
@h-vetinari h-vetinari requested a review from a team as a code owner December 12, 2024 11:44
@h-vetinari
Copy link
Member Author

I'm fine for this PR to get squashed, if someone prefers that. I didn't squash the PR myself to show why I arrived at the solution here. Note that the following sed-command

sed -i '/^enabled=/d; /^\[/a\enabled=0' /etc/yum.repos.d/CentOS-Base.repo

is pretty gnarly to understand, and in particular, I couldn't find a way to chain another append-command afterwards.

I added some comments to explain a bit what's going on. Whereas the regex for cos7 unconditionally disables something (so adding enable=0 everywhere is fine), here we only want to activate CRB resp. PowerTools, but without their sources or debuginfo flavours; hence we need two append commands.

Copy link
Member

@jaimergp jaimergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but I'd prefer if someone else can also take a look before merging because I'm not that in touch with this part of the stack.

@h-vetinari
Copy link
Member Author

Ping @conda-forge/core, would be nice if someone could review. :)

@isuruf isuruf merged commit 79c622b into conda-forge:main Dec 17, 2024
14 checks passed
@h-vetinari h-vetinari deleted the crb branch December 17, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants