Add a CI job that builds a Docker multi-arch manifest list #249
Conversation
... from the images built by the `build` CI job Push manifest lists for both DockerHub (docker.io) and Quay.io registries. Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| docker-registry: [docker.io/condaforge, quay.io/condaforge] |
There was a problem hiding this comment.
It is not possible to use the env vars here (REGISTRY_DH and REGISTRY_QUAY) :-/
There was a problem hiding this comment.
Unfortunately this also does not work!
commit: martin-g@426b612
error: https://github.com/martin-g/docker-images/actions/runs/7474578018
Fails with:
Invalid workflow file: .github/workflows/ci.yaml#L291
You have an error in your yaml syntax on line 291
| - DOCKER_MANIFEST: linux-anvil-ubi-cuda | ||
| DOCKER_TAG: "11.0" | ||
| DOCKER_IMAGES: "<<ORG>>/linux-anvil-cuda:<<TAG>>,<<ORG>>/linux-anvil-ppc64le-cuda:<<TAG>>,<<ORG>>/linux-anvil-aarch64-cuda:<<TAG>>" | ||
| - DOCKER_MANIFEST: linux-anvil-cos7-cuda |
There was a problem hiding this comment.
There is some repetition for all DOCKER_MANIFEST: linux-anvil-cos7-cuda but I wasn't able to compose a more compact matrix (e.g. by using DOCKER_TAG: ["11.1", "11.2", "11.3", ...]).
There was a problem hiding this comment.
That's ok. We already have some repetition for the CUDA images
Also longer term we are slowly phasing the CUDA images out entirely. It will take us some time to get there though
We could probably take this opportunity to drop CUDA 11.0 & 11.1 as we don't use those any more ( conda-forge/conda-forge-pinning-feedstock#1708 )
There was a problem hiding this comment.
Do you suggest to drop them in this PR or in another ?
There was a problem hiding this comment.
We don't need to do in this PR. Just if they are causing difficulty, we should feel comfortable dropping them
|
Could someone please re-run |
|
Any more feedback on the proposed changes ? |
|
Happy New Year Martin! 🎉 Glad to hear from you 🙂 Was wondering about this as well. In particular was wondering if you wanted to try out the suggestions in this thread ( #249 (comment) ) Please let me know what you think |
|
Happy New Year @jakirkham ! 🎉 |
|
Hey Martin, sorry for letting this linger for so long. Would it be possible to refresh this PR? We have collapsed the CUDA matrix to CUDA 11.8. We added Alma 8. Also we have done some other cleanup of the images (and how they are built). Am hoping this makes things more manageable since we last worked on this Please let me know what you think 🙂 |
|
Hi @jakirkham ! |
|
Thanks Martin! 🙏 |
... from the images built by the
buildCI jobPush manifest lists for both DockerHub (docker.io) and Quay.io registries.
Checklist
Fixes #102