PPC: add 11.0, 11.1, 11.2 + cached cudatoolkit pkg #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimergp
changed the title
isuruf
reviewed
Apr 19, 2021
.github/workflows/ci.yaml
Outdated
Comment on lines
93
to
95
| DOCKERTAG: "9.2" | ||
| CUDA_VER: "9.2" | ||
| CENTOS_VER: "7" |
There was a problem hiding this comment.
Please keep this as it is for now. It's used by some feedstocks.
jaimergp
changed the title
|
Hm, CUDA 11.2 has a weird locale issue? |
6 tasks
|
@isuruf Can you check if this is ok now? I had to add one more package to CentOS 8 builds because the US UTF8 locale is not installed by default in these images. |
leofang
reviewed
Apr 23, 2021
| @@ -69,6 +85,21 @@ RUN source /opt/conda/etc/profile.d/conda.sh && \ | |||
| chgrp -R lucky /opt/conda && \ | |||
| chmod -R g=u /opt/conda | |||
|
|
|||
| # Download and cache CUDA related packages. | |||
| RUN if [[ "$CUDA_VER" == "9.2" || "$CUDA_VER" == "10.0" || "$CUDA_VER" == "10.1" ]]; then \ | |||
| echo "`cudatoolkit` not available for CUDA_VER<10.2"; \ | |||
There was a problem hiding this comment.
Just a nitpick: maybe we should error out here?
There was a problem hiding this comment.
I think Isuru wants them around because they are being used somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)I am adding PPC64LE images for CUDA 11.0 and 11.1, with cached
cudatoolkittoo. Since we are not packagingcudatoolkitfor <10.2 (see conda-forge/cudatoolkit-feedstock#12), those won't cache it.