Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for CUDA12.6.0 #24

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented Aug 2, 2024

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
  • You're setting a requirement on sysroot_linux- directly; this should now be done by adding a build dependence on {{ stdlib("c") }}, and overriding c_stdlib_version in recipe/conda_build_config.yaml for the respective platform as necessary. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

@adibbley
Copy link
Contributor Author

adibbley commented Aug 2, 2024

@conda-forge-admin, please restart ci

@adibbley
Copy link
Contributor Author

adibbley commented Aug 2, 2024

@conda-forge-admin, please restart ci

@adibbley
Copy link
Contributor Author

adibbley commented Aug 2, 2024

@conda-forge-admin, please lint

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jakirkham
Copy link
Member

@conda-forge-admin, please rerender

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/cuda-nvcc-impl-feedstock/actions/runs/10220814745.

@adibbley
Copy link
Contributor Author

adibbley commented Aug 2, 2024

I've been hitting that rerender error as well, doing it locally does work though.

@jakirkham
Copy link
Member

The re-rendering is complaining it did not know how to define platform in this block

{% set platform = "linux-x86_64" %} # [linux64]
{% set platform = "linux-ppc64le" %} # [ppc64le]
{% set platform = "linux-sbsa" %} # [aarch64]

@jakirkham
Copy link
Member

What version of conda-build do you have locally?

@adibbley
Copy link
Contributor Author

adibbley commented Aug 2, 2024

24.5.0

@jakirkham
Copy link
Member

jakirkham commented Aug 2, 2024

Ok so maybe this is a bug with the recently released conda-build version 24.7.1: conda-forge/conda-build-feedstock#229

Edit: Interesting that building the package doesn't run into this issue. Must have something to do with where conda-smithy hooks into conda-build

@jakirkham
Copy link
Member

jakirkham commented Aug 2, 2024

Just to confirm, are you using conda-smithy version 3.37.2?

@adibbley
Copy link
Contributor Author

adibbley commented Aug 2, 2024

Yes

@adibbley adibbley marked this pull request as ready for review August 2, 2024 19:26
@adibbley adibbley requested a review from a team as a code owner August 2, 2024 19:26
@adibbley adibbley added the automerge Merge the PR when CI passes label Aug 2, 2024

-TOP = $(_HERE_)/..
+TOP = $(_HERE_)/../$(_TARGET_DIR_)

CICC_PATH = $(TOP)/nvvm/bin
CICC_NEXT_PATH = $(TOP)/nvvm-next/bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertmaynard am assuming this is ok since this is dropped from the source file. We were not patching this line. Though please let us know if we need to change anything here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah missed Rob is out today. Think we should be ok here. So let's go ahead and merge

We can follow up with Rob when he get back

@adibbley
Copy link
Contributor Author

adibbley commented Aug 2, 2024

Pulled your changes and local rerender had no further changes, adding automerge. Thanks John!

@github-actions github-actions bot merged commit 00a6db0 into conda-forge:main Aug 2, 2024
5 checks passed
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham
Copy link
Member

Regarding the re-rendering issue, filed upstream issue: conda-forge/conda-smithy#2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants