Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mingw - part 2 #134

Merged
merged 29 commits into from
Jun 12, 2024
Merged

Mingw - part 2 #134

merged 29 commits into from
Jun 12, 2024

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented May 14, 2024 •
edited
Loading

@conda-forge-admin, rerender.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari mentioned this pull request Jun 3, 2024
Merged
4 tasks
h-vetinari
h-vetinari reviewed Jun 3, 2024
View reviewed changes
recipe/meta.yaml
{% if cross_target_platform.startswith("win-") %}
{% set runtime_suffix = "" %}
{% else %}
{% set runtime_suffix = "-ng" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Longterm it would be nice to get rid of the runtime suffix everywhere; the last respective linux builds are:

This should be fixable with some simple run-constraints (plus keeping -ng as a wrapper until we've switched over the strong run-exports for maybe a few years).

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

Re d875cfd, I don't think we need to work around the smithy bug. If the red X here bothers you, we should just cut a new smithy release (I didn't push for one because of other nearly finished PRs and not considering it very urgent).

@isuruf
Copy link
Member Author

isuruf commented Jun 11, 2024

Thanks. It'd be good to have a new release. I would've ignored a false positive, but this was failing conda-smithy, so I have to run conda-smithy locally every time.

@isuruf isuruf added the automerge Merge the PR when CI passes label Jun 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 11, 2024 •
edited
Loading

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Jun 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@isuruf isuruf added the automerge Merge the PR when CI passes label Jun 11, 2024
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Jun 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@h-vetinari
Copy link
Member

I would've ignored a false positive, but this was failing conda-smithy, so I have to run conda-smithy locally every time.

It should just fail the linter, not the rerender?

@isuruf
Copy link
Member Author

isuruf commented Jun 12, 2024

It should just fail the linter, not the rerender?

Yes, I meant the linter.

@isuruf isuruf added the automerge Merge the PR when CI passes label Jun 12, 2024
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@h-vetinari
Copy link
Member

GCC server looks like it's down. https://gcc.gnu.org/pipermail/gcc/ is affected too.

@isuruf isuruf added the automerge Merge the PR when CI passes label Jun 12, 2024
@github-actions github-actions bot merged commit 8ac7fcc into conda-forge:main Jun 12, 2024
63 checks passed
@h-vetinari h-vetinari mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

@beckermr beckermr Awaiting requested review from beckermr beckermr is a code owner

@timsnyder timsnyder Awaiting requested review from timsnyder timsnyder is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isuruf @h-vetinari