Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve linter warning messages a tad #1943

Merged
merged 1 commit into from
May 29, 2024
Merged

improve linter warning messages a tad #1943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions conda_smithy/lint_recipe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,8 @@ def check_pins_build_and_requirements(top_level):

stdlib_hint = (
"This recipe is using a compiler, which now requires adding a build "
'dependence on `{{ stdlib("c") }}` as well. For further details, please '
'dependence on `{{ stdlib("c") }}` as well. Note that this rule applies to '
"each output of the recipe using a compiler. For further details, please "
"see https://github.com/conda-forge/conda-forge.github.io/issues/2102."
)
pat_compiler_stub = re.compile(
Expand Down Expand Up @@ -1028,8 +1029,8 @@ def sort_osx(versions):
# only warn if version is below baseline
outdated_hint = (
"You are setting `c_stdlib_version` below the current global baseline "
"in conda-forge. If this is your intention, you also need to override "
"`MACOSX_DEPLOYMENT_TARGET` (with the same value) locally."
"in conda-forge (10.13). If this is your intention, you also need to "
"override `MACOSX_DEPLOYMENT_TARGET` (with the same value) locally."
)
if len(v_stdlib) == len(macdt):
# if length matches, compare individually
Expand All @@ -1056,8 +1057,8 @@ def sort_osx(versions):
"(you can leave it out if it is equal).\n"
"If you are not setting `c_stdlib_version` yourself, this means "
"you are requesting a version below the current global baseline in "
"conda-forge. In this case, you also need to override "
"`c_stdlib_version` and `MACOSX_DEPLOYMENT_TARGET` locally."
"conda-forge (10.13). If this is the intention, you also need to "
"override `c_stdlib_version` and `MACOSX_DEPLOYMENT_TARGET` locally."
)
if len(sdk) == len(merged_dt):
# if length matches, compare individually
Expand Down
Loading