Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze Sphinx content to Markdown #2084

Merged
merged 23 commits into from
Feb 26, 2024

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Feb 23, 2024

PR Checklist:

  • note any issues closed by this PR with closing keywords

  • put any other relevant information below

  • Part of Redesigning conda-forge.org #1971

  • In the last conda-forge core call meeting, we discussed the pros and cons of removing the render-to-markdown pipeline altogether because the maintenance complexity was not worth in the long run and Sphinx was not providing any features we were really missing in Docusaurus. In this PR I have rendered /docs permanently and reworked some 00_intro.html pages with Docusaurus-equivalent features (card lists, mostly).

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for conda-forge-previews ready!

Name Link
🔨 Latest commit 9061d66
🔍 Latest deploy log https://app.netlify.com/sites/conda-forge-previews/deploys/65dc40c70ae9b9000863119b
😎 Deploy Preview https://deploy-preview-2084--conda-forge-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaimergp jaimergp marked this pull request as ready for review February 23, 2024 13:48
@jaimergp jaimergp requested a review from a team as a code owner February 23, 2024 13:48
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that some of the static content images have been moved? This may break the status page again.

@beckermr
Copy link
Member

We should either keep the links the same or go back and fix the status page later.

@jaimergp
Copy link
Member Author

It appears that some of the static content images have been moved? This may break the status page again.

When we fixed it last time we pinned the commit hash, so it should be ok.

@jaimergp
Copy link
Member Author

One awesome part of having in everything in Docusaurus is that we can leverage the cool bits of the JS world. Like this live editor with built-in preview:

https://stackblitz.com/github/jaimergp/conda-forge.github.io/tree/render-markdown-once?file=docs%2Findex.md

Copy link
Contributor

@zklaus zklaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants