-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conda-forge.org redesign: Homepage #2050
Conversation
* add pages about the packaging life cycle * add pre-commit checks * prettier * comment out some stuff * retrigger * use prettier only, with types_or * Some more work on infrastructure components per stage. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add some authentication details * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * document some more stuff about feedstocks * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * save wip * disable pr autocommit * pre-commit * add WIP marks * change favicon temporarily * a bit more WIP Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* push wip * some more * Rename + diataxis cleanup :D * remove old block * pre-commit * fix 404s * clean up infra index * rename to organization * update feedstocks docs * update staged-recipes docs * update github resources * update website * use organization spelling * pre-commit * merge tooling and data * aggregate a bit better * rename * add easy-to-digest info about runners and pinnings * import glossary * a few more services * fix link * pre-commit * address some parts of the code review * use cards * some more links * rephrase * some links * add some descriptions * some more menu work * a bit more * pre-commit
* Add prelimar diagrams * add mermaid mindmap (draft) * pre-commit --------- Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
* change text in frontpage * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* feat: implement fonts and header Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * accept suggested changes Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * accept suggested changes Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> * feat: update custom.css file with final changes * feat: implement final header * feat: add about section * feat: add contributing section * feat: add supporters section * feat: update navbar to match dashboard design * feat: add styleguide * fix: add suggested changes * Update docusaurus.config.js --------- Signed-off-by: Asmit Malakannawar <asmitbm2952002@gmail.com> Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
Migrate existing blog posts
* adjust supporter logos * shuffle order * fix azure link * add cirun and quansight to infra * link whole card * fix color * remove randomizer (breaks links in dark/light switches) * pre-commit
* reorg variables * status colors * implement teal theme * adjust primary, dark and light for AA compliance * fix hyperlink states * fix footer link hover * prettier * fix active menu color in dark mode * fix homepage button active * pre-commit * add some docstrings * fix link colors in cards and hover animations * link contributing cards to something * pre-commit
* update hex colors in style guide * add info about css sources
* fix fiscal-sponsor hover * fix mobile responsiveness
Filtered to homepage only using https://stackoverflow.com/a/69948894
…nto docusaurus-homepage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we get permission from github to post their logo and name them as a supporter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't send any message, only read https://github.com/logos and thought it would be "ok". But it's true that I'd rather err on the side of caution. I'll comment out the JSX code that adds Github and Azure for now. At some point I might send a couple emails. Thanks for the note!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this statement is on the "no" list:
Do not use the GitHub name or any GitHub logo in a way that suggests you are GitHub, your offering or project is by GitHub, or that GitHub is endorsing you or your offering or project.
We don't want to call them a supporter and thus imply they endorse us. Or at least that is my worry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we get permission from azure devops to post their logo?
Just two questions and then happy to merge. |
Missed the CNAME. https://conda-forge.github.io/ does work. Fix incoming. |
Thanks Jaime and Matt! 🙏 In the future would it make sense to leave PRs like this open a bit longer to review? With this particular change (the home page), this is basically what we looked at before the break with some color changes that were discussed. As folks were largely on-board, am less worried about that However with some of the other doc changes, it might be good to make some space for more feedback. Does that seem reasonable? |
PR Checklist:
Part of #1971.
This enables the new homepage only, as demoed in https://cf-infra-docs.netlify.app/, but with some navigation changes to point to the old parts of the site.
Thanks to #2049, the Sphinx tree now lives in its own subdirectory. What we are doing is to render Sphinx first to its own
_build/html
directory. From there we fetch everything and put in understatic-sphinx
, which has been configured as an additionalstatic
source in Docusaurus (i.e. files get copied blindly to root from there).Then we run
npm run build
to build the Docusaurus website, which for now only includes the homepage @asmitbm designed and a couple static pages. There are a couple adjustments needed due to Docusaurus' SPA navigation (thepathname://
business), but that's only a temporary measure because in the end we should have, at least, a site fully rendered by Docusaurus (even if the docs are pre-rendered by Sphinx to Markdown, themed HTML generation would be done by Docusaurus).To preview locally: