Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some docs: osx vmImage, sdks, and metal #1638

Closed
wants to merge 8 commits into from
Closed

Conversation

ngam
Copy link
Contributor

@ngam ngam commented Mar 25, 2022

Fixes #1635 (this is an opening draft; let's try to get this to a good state before merging)

cc @isuruf for review if possible, also cc @BastianZim for awareness/consultation

PR Checklist:

  • make all edits to the docs in the src directory, not in docs or in the html files
  • note any issues closed by this PR with closing keywords
  • put any other relevant information below

@ngam ngam requested a review from a team as a code owner March 25, 2022 01:19
Comment on lines +1139 to +1141
but Azure pipelines only offer the latest of 11, ``macOS-11``, which
at the time of writing (March 2022) is 11.6. (Currently, the ``macOS-12`` vmImage is in
private preview.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw can we comment on the M1 target? I don't think this is applicable to osx-arm64?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's not applicable to osx-arm64? I noted earlier that the default SDK for osx-arm64 is 11 in the conda-forge workflow, but I can repeat that here. Is this what you mean?

Copy link
Member

@leofang leofang Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to vmImage. Would this option be honored for the M1 target? I thought M1 is always built on 11?

Copy link
Contributor Author

@ngam ngam Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think so. Plus, this is really only important for testing in my experience. You can build for osx-arm64 with the older vmImage and it will be just fine (that's what's done anyway, I think) as you only need to specify the targets as usual.

Specifying the vmImage only matters (again, in my experience) if you want to test your build in another package. For example, I had libtvm built for deployment target 11, then I had tvm-py that pulls in libtvm, but it fails to pull it in unless the vmImage is 11+. I am not actually sure about testing in the same package --- I assume it may work just fine maybe with some warnings, but I guess generally, it's better to specify.

But I should probably test this a little more to make sure everything makes sense before we merge.

Copy link
Contributor Author

@ngam ngam Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as far as I could tell, specifying the vmImage has no real benefits other than this narrow case above.

Co-authored-by: Bastian Zimmermann <10774221+BastianZim@users.noreply.github.com>
Comment on lines +1139 to +1141
but Azure pipelines only offer the latest of 11, ``macOS-11``, which
at the time of writing (March 2022) is 11.6. (Currently, the ``macOS-12`` vmImage is in
private preview.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw can we comment on the M1 target? I don't think this is applicable to osx-arm64?

@ngam
Copy link
Contributor Author

ngam commented Apr 10, 2022

@isuruf @conda-forge/core for a review, thanks!

@ngam
Copy link
Contributor Author

ngam commented Apr 23, 2022

will attempt again later, closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

improve docs re osx sdks
3 participants