-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe definition added #1395
Recipe definition added #1395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this addition to the glossary is valid, but the link in the main page still looks kinda strange to me (though I liked it )
Basically we don't have separate links for every definition in the glossary, ( although i think there should be) so it felt strange to me also. But if you want we can remove the links from homepage. |
@beckermr any thoughts on this? (My idea was set it and check if someone complains ;p) |
@viniciusdc @beckermr now as I think more, I think there is absolutely a need for separate links/references to different glossary descriptions so that they can be properly referenced in other places. |
I don't have a preference here. |
Co-authored-by: Aaishpra <Aaishpra@users.noreply.github.com>
Integrated in #2087. Thanks! |
* rework glossary * Bring #1363 Co-authored-by: angeloobeta <angeloobeta@users.noreply.github.com> * Bring #1395 Co-authored-by: Aaishpra <Aaishpra@users.noreply.github.com> * These are not acronyms * adjust editURL so it works with new pages introduced by PRs * dump context (debug) * use event payload * extend http codes considered valid --------- Co-authored-by: angeloobeta <angeloobeta@users.noreply.github.com> Co-authored-by: Aaishpra <Aaishpra@users.noreply.github.com>
Recipe definition added to glossary and links in homepage added
PR Checklist:
Fixes: #1389
src
directory, not indocs
or in the html files