Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recipe definition added #1395

Closed
wants to merge 3 commits into from
Closed

Recipe definition added #1395

wants to merge 3 commits into from

Conversation

Aaishpra
Copy link
Contributor

Recipe definition added to glossary and links in homepage added

PR Checklist:

image

Fixes: #1389

  • make all edits to the docs in the src directory, not in docs or in the html files
  • note any issues closed by this PR with closing keywords
  • put any other relevant information below

@Aaishpra Aaishpra requested a review from a team as a code owner April 20, 2021 11:44
viniciusdc
viniciusdc reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this addition to the glossary is valid, but the link in the main page still looks kinda strange to me (though I liked it )

@Aaishpra
Copy link
Contributor Author

Basically we don't have separate links for every definition in the glossary, ( although i think there should be) so it felt strange to me also. But if you want we can remove the links from homepage.

@viniciusdc
Copy link
Contributor

Basically we don't have separate links for every definition in the glossary, ( although i think there should be) so it felt strange to me also. But if you want we can remove the links from homepage.

@beckermr any thoughts on this? (My idea was set it and check if someone complains ;p)

@Aaishpra
Copy link
Contributor Author

@viniciusdc @beckermr now as I think more, I think there is absolutely a need for separate links/references to different glossary descriptions so that they can be properly referenced in other places.
Something like here, where we have different sub-headings as well as references for every config.
If you think this can be worked on, I would like to open an issue and work on the same.

@beckermr
Copy link
Member

I don't have a preference here.

@Aaishpra Aaishpra mentioned this pull request Apr 24, 2021
Open
1 task
jaimergp added a commit to jaimergp/conda-forge.github.io that referenced this pull request Feb 26, 2024
@jaimergp @Aaishpra
Bring conda-forge#1395
6cb0b12 
Co-authored-by: Aaishpra <Aaishpra@users.noreply.github.com>
@jaimergp jaimergp mentioned this pull request Feb 26, 2024
Merged
2 tasks
@jaimergp
Copy link
Member

Integrated in #2087. Thanks!

@jaimergp jaimergp closed this Feb 28, 2024
jaimergp added a commit that referenced this pull request Feb 28, 2024
@jaimergp @angeloobeta @Aaishpra
Rework glossary (#2087)
451f1c1 
* rework glossary

* Bring #1363

Co-authored-by: angeloobeta <angeloobeta@users.noreply.github.com>

* Bring #1395

Co-authored-by: Aaishpra <Aaishpra@users.noreply.github.com>

* These are not acronyms

* adjust editURL so it works with new pages introduced by PRs

* dump context (debug)

* use event payload

* extend http codes considered valid

---------

Co-authored-by: angeloobeta <angeloobeta@users.noreply.github.com>
Co-authored-by: Aaishpra <Aaishpra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniciusdc viniciusdc viniciusdc left review comments

@ForgottenProgramme ForgottenProgramme ForgottenProgramme left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What is a recipe ?
5 participants
@Aaishpra @viniciusdc @beckermr @jaimergp @ForgottenProgramme