Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for python312 #691

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update python312.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8466004127, please use this URL for debugging.

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner March 28, 2024 11:32
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@beckermr
Copy link
Member

@conda-forge/core this pr is odd. Idk why smithy thinks we need compiler keys here. Any ideas?

c_stdlib:
- sysroot
c_stdlib_version:
- '2.12'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you talking about this @beckermr?

AFAIU that would be a simple consequence of having those keys listed in smithy's always_keep_keys.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can not put it there since conda-build is fixed now?

Copy link
Member

@h-vetinari h-vetinari Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we require conda-build >=24.3, then yes, it should be possible to remove.

I mainly followed MACOSX_DEPLOYMENT_TARGET being part of that list as well, and not managing to get things to work if I removed it from there. Perhaps the last refactor that also transforms squished_input_values now makes this possible...

I'm without a laptop until April 7th though, so won't be able to open a PR. Feel free to try though, the tests in smithy should cover the most important cases I hope.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold off for a while then. We can come back and cleanup later once the dust has settled.

@beckermr
Copy link
Member

@conda-forge-admin rerender

Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/actions/runs/8472552888.

@beckermr beckermr added the automerge Merge the PR when CI passes label Mar 28, 2024
@github-actions github-actions bot merged commit d18d148 into conda-forge:main Mar 28, 2024
4 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants