Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH add migration for gcc 9.3.0 #837

Merged
merged 7 commits into from
Oct 8, 2020
Merged

Conversation

beckermr
Copy link
Member

@beckermr beckermr commented Oct 7, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@beckermr beckermr requested a review from isuruf October 7, 2020 14:21
beckermr and others added 2 commits October 7, 2020 09:25
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
@beckermr
Copy link
Member Author

beckermr commented Oct 7, 2020

This is waiting on the rebuild of gfortran on osx so that the hashes in the compilers are unique.

@beckermr beckermr marked this pull request as ready for review October 7, 2020 20:47
@beckermr beckermr requested a review from a team as a code owner October 7, 2020 20:47
@isuruf
Copy link
Member

isuruf commented Oct 7, 2020

Aren't we going to build both?

@isuruf
Copy link
Member

isuruf commented Oct 7, 2020

Can you also clean up the versions in conda_build_config.yaml?

@beckermr
Copy link
Member Author

beckermr commented Oct 7, 2020

Build both versions of gfortran?

@beckermr
Copy link
Member Author

beckermr commented Oct 7, 2020

Aren't we going to build both?

I still don't follow this question @isuruf.

I think I got the rest of the changes.

@isuruf
Copy link
Member

isuruf commented Oct 7, 2020

I was under the impression that this will take a long time as well and that we should build both versions (7 and 9) to not interfere other migrations.

@beckermr
Copy link
Member Author

beckermr commented Oct 7, 2020

Ahhhh. I can put back the version 7 on osx and linux. We don't need it on aarch or ppc since the SONAME is the same.

@isuruf
Copy link
Member

isuruf commented Oct 7, 2020

aarch64 used 7.*. For ppc64le, we still need to rebuild for the new run_exports to work (unless we do a repodata patch).

@beckermr
Copy link
Member Author

beckermr commented Oct 7, 2020

@conda-forge/core as currently set up, this migration will remove any compiler pins related to armv7l builds. Do we need those platforms at all?

@beckermr
Copy link
Member Author

beckermr commented Oct 7, 2020

aarch64 used 7.*. For ppc64le, we still need to rebuild for the new run_exports to work (unless we do a repodata patch).

Right. I think I got the old 7 platforms correct. I can add 8 for ppc64le

@jjhelmus
Copy link
Contributor

jjhelmus commented Oct 7, 2020

@conda-forge/core as currently set up, this migration will remove any compiler pins related to armv7l builds. Do we need those platforms at all?

The armv7l platform can be removed, it is not being built. If someone wants to add this platform to conda-forge in the future they can re-add the correct pins.

@beckermr
Copy link
Member Author

beckermr commented Oct 7, 2020

great @jjhelmus! I think this is ready to merge then!

@beckermr
Copy link
Member Author

beckermr commented Oct 8, 2020

Any other comments here @conda-forge/core?

@beckermr
Copy link
Member Author

beckermr commented Oct 8, 2020

announcement here: conda-forge/conda-forge.github.io#1166

@beckermr beckermr merged commit ddcb1d6 into conda-forge:master Oct 8, 2020
@beckermr beckermr deleted the gcc930 branch October 8, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants