-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH add migration for gcc 9.3.0 #837
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
This is waiting on the rebuild of gfortran on osx so that the hashes in the compilers are unique. |
Aren't we going to build both? |
Can you also clean up the versions in |
Build both versions of gfortran? |
I still don't follow this question @isuruf. I think I got the rest of the changes. |
I was under the impression that this will take a long time as well and that we should build both versions (7 and 9) to not interfere other migrations. |
Ahhhh. I can put back the version 7 on osx and linux. We don't need it on aarch or ppc since the SONAME is the same. |
aarch64 used 7.*. For ppc64le, we still need to rebuild for the new run_exports to work (unless we do a repodata patch). |
@conda-forge/core as currently set up, this migration will remove any compiler pins related to armv7l builds. Do we need those platforms at all? |
Right. I think I got the old 7 platforms correct. I can add 8 for ppc64le |
The |
great @jjhelmus! I think this is ready to merge then! |
Any other comments here @conda-forge/core? |
announcement here: conda-forge/conda-forge.github.io#1166 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)