Add is_abi3 and is_python_min helper variables #6896
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
I just worked on something today where this would have come in handy (even though it was a pretty niche use-case; see cython feedstock), so fine from my POV. Would be interested what cases you had in mind.
The one downside is that this will break all recipes that override the python-zip, but there aren't many of those luckily
|
My use-case is for ABI3 packages. See the example recipe at https://github.com/conda-forge/staged-recipes/pull/28743/files#diff-bafedb486e7a5dc8c3acc5a3efb089e495842a60d83dd07daa8720ae9615dea0 |
|
Thanks for the review |
|
Oh, did you want me to wait for a review from another? |
Nah, all good. Thanks for the |
| is_abi3: | ||
| - true |
There was a problem hiding this comment.
Should is_abi3 be zipped with is_freethreading? Otherwise it seems we would just turn off ABI3 completely when a free-threading build is added
| @@ -34,6 +34,7 @@ __migrator: | |||
| additional_zip_keys: | |||
| - channel_sources | |||
| - is_freethreading | |||
| - is_abi3 | |||
There was a problem hiding this comment.
@jakirkham, is_abi3 is zipped in freethreading migrator
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)