Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close out migration for libgrpc159_libprotobuf4244 #5559

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to close out the migration for libgrpc159_libprotobuf4244.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8000574508, please use this URL for debugging.

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner February 22, 2024 08:42
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ocefpaf ocefpaf merged commit 975d574 into conda-forge:main Feb 22, 2024
4 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-libgrpc159_libprotobuf4244-0-1_h56e877 branch February 22, 2024 13:38
Comment on lines -107 to +108
MACOSX_DEPLOYMENT_TARGET: # [osx]
- 11.0 # [osx and arm64]
- 10.9 # [osx and x86_64]
MACOSX_DEPLOYMENT_TARGET: # [osx and x86_64]
- "10.13" # [osx and x86_64]
Copy link
Member

@h-vetinari h-vetinari Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so this is actually a pretty serious mis-merge. I'm going to revert this commit right now.

It's an unfortunate consequence of the situation in conda-forge/conda-forge.github.io#1844 that we cannot merge something like this yet without a lot of infrastructure work, but I'm working on this with a high degree of urgency and trying to do it right.

@conda-forge/core, in the meantime, please do not merge any changes to MACOSX_DEPLOYMENT_TARGET in the pinning repo (which unfortunately we require to be present for abseil/grpc/protobuf-related migrations - which is also the reason why libabseil20230802_libgrpc157_libprotobuf4234.yaml is still around, intentionally).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial revert in 0444152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants