Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to clang 16 #4991

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Bump to clang 16 #4991

merged 1 commit into from
Oct 5, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 4, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Split from #4890

@isuruf isuruf requested a review from a team as a code owner October 4, 2023 17:49
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Isuru! 🙏

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the simpler of the two compiler updates.

@jakirkham
Copy link
Member

Yeah and that is why we chose just to do Clang 16 and defer on GCC 13 for a bit

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this either way. My impression is that clang 16 will be more disruptive than GCC 13 (partially explained in #4890), but in any case, I'm in favour of keeping our compilers up to date.

One more argument in favour of doing only clang is that GCC 12 still receives bugfixes, while clang 15 is dead (actually clang 16 has topped out at 16.0.6 as well, but at least that means it has "converged" to its final state).

@isuruf
Copy link
Member Author

isuruf commented Oct 5, 2023

Thanks @h-vetinari for the PR and building clang-16

@isuruf isuruf merged commit 7798f0f into conda-forge:main Oct 5, 2023
4 checks passed
@h-vetinari h-vetinari mentioned this pull request May 4, 2024
16 tasks
@h-vetinari h-vetinari mentioned this pull request Oct 20, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants