Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 22.11.0 #181

Merged
merged 10 commits into from
Dec 2, 2022
Merged

Release 22.11.0 #181

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c4c931c
Get rid of patch.
jezdez Nov 30, 2022
fbafe2d
Update to 22.11.0.
jezdez Nov 30, 2022
2ac7444
MNT: Re-rendered with conda-build 3.23.1, conda-smithy 3.22.0, and co…
Nov 30, 2022
938f804
Bump ruaml.yaml.
jezdez Nov 30, 2022
f0b61d7
Remove me as a maintainer
mcg1969 Nov 30, 2022
897f22e
MNT: Re-rendered with conda-build 3.23.1, conda-smithy 3.22.0, and co…
Nov 30, 2022
de8ab64
Move tqdm into host section.
jezdez Dec 1, 2022
3b24f3b
Add tqdm to run section as well.
jezdez Dec 1, 2022
fe4ec8d
Skip PyPy
jezdez Dec 1, 2022
c4e9cb7
MNT: Re-rendered with conda-build 3.23.2, conda-smithy 3.22.0, and co…
Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

119 changes: 0 additions & 119 deletions recipe/gh9946_utf_16_replacement.patch
View file
Open in desktop

This file was deleted.

22 changes: 12 additions & 10 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{% set on_win = SUBDIR in ('win-64', 'win-32') %}
{% set version = "22.9.0" %}
{% set name = "conda" %}
{% set version = "22.11.0" %}
{% set sha256 = "f280c1e68601adbfacb63d71d7319b0067f9e2543bb56b98d8093d22617ee42e" %}
# Running pytest requires the inclusion of test files which baloons
# the size of the package; values can be "yes" or "no"
{% set run_pytest = "no" %}
Expand All @@ -10,13 +12,11 @@ package:

source:
fn: conda-{{ version }}.tar.gz
url: https://github.com/conda/conda/archive/{{ version }}.tar.gz
sha256: 35c924fab82e1be7a3359494ff02eab2b2d9b04004cc689e41f84edc1fb853c0
patches:
- gh9946_utf_16_replacement.patch
url: https://github.com/conda/{{ name }}/archive/{{ version }}.tar.gz
sha256: {{ sha256 }}

build:
number: 2
number: 0
# These are present when the new environment is created
# so we have to exempt them from the list of initial files
# for conda-build to realize they should be included.
Expand All @@ -41,19 +41,22 @@ requirements:
- conda-package-handling >=1.3.0
- menuinst >=1.4.11,<2 # [win]
- pip
- ruamel_yaml >=0.11.14,<0.17
- ruamel.yaml >=0.11.14,<0.18
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beckermr That's something you think should be way more constraint, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on your tolerance for risk, but for sure there will be a tradeoff between broken envs, envs that don't solve, and maintenance to update pins.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would at least make the minimum version as big as possible, and I'm not a huge fan of pessimistic upper version pins.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can patch them out as needed. The issue is breakages which make envs unrecoverable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conda serialize module that redirects to pyyaml, and may or may not always use YAML().something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate a specific proposal of change here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/conda/conda/blob/main/conda/common/serialize.py#L47

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes here already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda's serialize module appears to use the current YAML().method form always, instead of the deprecated global yaml.load_safe() or whatever.

- setuptools >=31.0.1
- toolz >=0.8.1
- pluggy >=1.0.0
run:
- python
- conda-package-handling >=1.3.0
- menuinst >=1.4.11,<2 # [win]
- pycosat >=0.6.3
- pyopenssl >=16.2.0
- requests >=2.20.1,<3
- ruamel_yaml >=0.11.14,<0.17
- ruamel.yaml >=0.11.14,<0.18
- setuptools >=31.0.1
- toolz >=0.8.1
- pluggy >=1.0.0
- tqdm >=4
run_constrained:
- conda-build >=3
- conda-content-trust >=0.1.1
Expand Down Expand Up @@ -97,15 +100,14 @@ about:
summary: OS-agnostic, system-level binary package and environment manager.
description: >
Conda is an open source package management system and environment management system for installing multiple versions of software packages and their dependencies and switching easily between them. It works on Linux, OS X and Windows, and was created for Python programs but can package and distribute any software.
doc_url: https://conda.io/projects/conda/en/latest/
doc_url: https://docs.conda.io/projects/conda/en/stable/
dev_url: https://github.com/conda/conda

extra:
recipe-maintainers:
- isuruf
- jakirkham
- kalefranz
- mcg1969
- mingwandroid
- msarahan
- mwcraig
Expand Down