-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adapted powershell activations #43
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This is a good question that I don't know the answer to, but presumably, if you're in powershell, the Also, please back out the rerender-commit; current conda-build does not rerender this feedstock correctly, and it needs an unreleased version to work (see #42) |
…, and conda-forge-pinning 2024.08.20.12.29.15" This reverts commit 4f14a3b.
The activation .bat for VC is... quite complicated, but reading through it, seems to be mostly relevant for CMake. They have a couple year old issue for powershell support, but I think it's probably a bit beyond my abilities. That said, I've just tried this locally, and it worked for my use case in powershell without any changes to the Visual studio activation. I've also reverted the rerender. Thanks @h-vetinari |
Gentle ping @h-vetinari |
I wanted to give the other maintainers here some time to respond, but I guess nothing will break from adding powershell scripts, and if they turn out buggy in some way, we can still fix them later. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Closes #41.
The comment in install-pkg.bat about vs activation needing to run first made me realize I'm not sure if https://github.com/conda-forge/vc-feedstock/blob/main/recipe/activate.bat also needs a powershell version for this to work, or if the ordering is just because this sets some of the same variables and therefore needs to run second