Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adapted powershell activations #43

Merged
merged 7 commits into from
Aug 24, 2024
Merged

Add adapted powershell activations #43

merged 7 commits into from
Aug 24, 2024

Conversation

WardBrian
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #41.

The comment in install-pkg.bat about vs activation needing to run first made me realize I'm not sure if https://github.com/conda-forge/vc-feedstock/blob/main/recipe/activate.bat also needs a powershell version for this to work, or if the ordering is just because this sets some of the same variables and therefore needs to run second

@WardBrian
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

conda-forge-webservices[bot] and others added 3 commits August 20, 2024 14:22
@h-vetinari
Copy link
Member

The comment in install-pkg.bat about vs activation needing to run first made me realize I'm not sure if https://github.com/conda-forge/vc-feedstock/blob/main/recipe/activate.bat also needs a powershell version for this to work, or if the ordering is just because this sets some of the same variables and therefore needs to run second

This is a good question that I don't know the answer to, but presumably, if you're in powershell, the .bat activation scripts don't get executed, and so you'll need one for vc as well. Can you open a PR that adds powershell activation there to discuss?

Also, please back out the rerender-commit; current conda-build does not rerender this feedstock correctly, and it needs an unreleased version to work (see #42)

…, and conda-forge-pinning 2024.08.20.12.29.15"

This reverts commit 4f14a3b.
@WardBrian
Copy link
Contributor Author

The activation .bat for VC is... quite complicated, but reading through it, seems to be mostly relevant for CMake. They have a couple year old issue for powershell support, but I think it's probably a bit beyond my abilities.

That said, I've just tried this locally, and it worked for my use case in powershell without any changes to the Visual studio activation.

I've also reverted the rerender. Thanks @h-vetinari

@WardBrian
Copy link
Contributor Author

Gentle ping @h-vetinari

@h-vetinari
Copy link
Member

I wanted to give the other maintainers here some time to respond, but I guess nothing will break from adding powershell scripts, and if they turn out buggy in some way, we can still fix them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add powershell activation scripts?
2 participants