Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition #46

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Fix condition #46

merged 1 commit into from
Nov 29, 2020

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Nov 29, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf isuruf added the automerge Merge the PR when CI passes label Nov 29, 2020
@isuruf isuruf merged commit 3f29243 into conda-forge:master Nov 29, 2020
Copy link
Contributor

@katietz katietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is ok. Out of curiousity, which issues you saw by '-ne' operator?

@isuruf
Copy link
Member Author

isuruf commented Nov 30, 2020

-ne operator expects integer expressions, but we are comparing strings.

@isuruf isuruf deleted the condition branch November 30, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants