-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v0.20.0 #12
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
Documentation on acceptable licenses can be found here. |
2bd3907
to
c74e69d
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
@willirath, I've put in a PR that should add the antarctic ice shelves to cartopy downloads: SciTools/cartopy#2097 In the meantime, there's a script here to do that. I'm downloading the cartopy source code here just so the bot will keep us in sync, though we don't really need to build a new package for every cartopy version. |
I'm running some tests with some downstream software (https://github.com/MPAS-Dev/MPAS-Analysis) to make sure there are no surprises. |
I agree. But closely following cartopy releases also provides immediate warning when cartopy changes anything that breaks our workflow here. |
With this update, we no longer use the cartopy_offlinedata package, we just download the data using cartopy itself.
…nda-forge-pinning 2022.10.21.19.23.23
ff96da1
to
3cef32c
Compare
Yep, good point. We can always make sure CI passes for each cartopy release even if we just close the PR after that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
All checks passing. @xylar do you want to do more tests, or should we merge? |
I got kicked off of the supercomputer where I was doing the testing without explanation! I'll try again elsewhere. |
I think my testing job is going to time out before it finishes but it would have shown a bunch of Download warnings if things weren't working. |
With this update, we no longer use the cartopy_offlinedata package, we just download the data using cartopy itself.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)closes #11