Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.12 rebuild #35

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Python 3.12 rebuild #35

merged 10 commits into from
Dec 4, 2023

Conversation

matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented Dec 1, 2023 •
edited
Loading

Followup of #30.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@matthiasdiener
Copy link
Contributor Author

@conda-forge-admin, please rerender

@matthiasdiener
Copy link
Contributor Author

Error message:

ERROR: Python version is incompatible. Found 3.12, which is not yet supported for package builds.

matthiasdiener
matthiasdiener commented Dec 4, 2023
View reviewed changes
recipe/ver.diff
Comment on lines +9 to +10
-python_max_p1_version = parse_version("3.12")
+python_max_p1_version = parse_version("3.13")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't part of the cantera repo yet, but it seems to work as expected (all tests pass with 3.12). I can create a PR to cantera if you like @bryanwweber .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah feel free, although I doubt we'll backport it and release 3.0.1 so this patch will be needed until 3.1 comes out

Copy link
Contributor Author

@matthiasdiener matthiasdiener Dec 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added this patch as a PR here Cantera/cantera#1648.

@matthiasdiener matthiasdiener mentioned this pull request Dec 4, 2023
Merged
5 tasks
@matthiasdiener matthiasdiener marked this pull request as ready for review December 4, 2023 21:12
bryanwweber
bryanwweber approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks!

@bryanwweber bryanwweber merged commit 5de4084 into conda-forge:main Dec 4, 2023
32 checks passed
@matthiasdiener matthiasdiener deleted the py312-manual branch December 4, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanwweber bryanwweber bryanwweber approved these changes

@inducer inducer Awaiting requested review from inducer inducer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthiasdiener @bryanwweber @regro-cf-autotick-bot