-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows version of 0.5.0 without vega-cli dependencies #7
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Would this even work without these requirements? Also: Why not build them for windows? They are node packages and should work there too. |
@xhochy , I'd love that. Getting vega-lite-cli and vega-cli builds for Windows would certainly be the superior solution. But see conda-forge/vega-cli-feedstock#4 and conda-forge/vega-cli-feedstock#3 |
@conda-forge-admin, please rerender |
…da-forge-pinning 2020.12.04.20.36.45
OK so this works, but I don't think this is a good idea. I'd rather have the vega-cli and vega-lite-cli dependencies fixed, or removed from this feedstock, or maybe with one subpackage without the dependencies (e.g. https://docs.conda.io/projects/conda-build/en/latest/resources/variants.html?#referencing-subpackages, https://github.com/conda-forge/dvc-feedstock/blob/master/recipe/meta.yaml) |
@jakevdp or any other Altair maintainer: Any suggestions here? |
FYI: I'm having some fun over at conda-forge/vega-cli-feedstock#8 and trying to package |
Thanks @xhochy . That would also be my preference. |
Thanks @xhochy. When I get the time, I might try changing this to use sub-packages instead. |
@jamesmyatt |
Thanks @xhochy. It certainly installs now :D However, I get a JSONDecodeError error now when using
|
Oh, that could also be an execution error from one of the underlying cli scripts. It's hard to tell from the traceback though what went wrong. |
Probably best if I open a new issue. Shall I open it here or in the main altair_saver repo? |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)See: altair-viz/altair_saver#70, altair-viz/altair_saver#121
vega-cli and vega-lite-cli do not have Windows builds on conda-forge. So it is possible to publish a conda package for Windows that doesn't require them?