Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gitlab 16.0 legacy urls removed #405

Merged
merged 1 commit into from
May 18, 2023

Conversation

m-roskrow
Copy link

as of gitlab 16.0 the commit URL no longer supports 'legacy' links: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed

the dash is now required to properly link to a commit, otherwise a 404 is returned

Signed-off-by: Michael Roskrow <michael.roskrow@finbourne.com>
Copy link
Member

@taylorsilva taylorsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylorsilva taylorsilva merged commit 1aa545a into concourse:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants