-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #233 error would clobber existing tag #234
Conversation
Update git fetch with -f -f, --force force overwrite of local reference Signed-off-by: talset <talset55@gmail.com>
Thanks! Could a test be added for this? i.e. use local repo with tags as |
I added a new test function Let me know if something need to be improved |
test/check.sh
Outdated
local ref3=$(make_commit_to_branch $repo branch-a) | ||
local ref4=$(make_annotated_tag $repo "staging" "tag branch-a") | ||
|
||
check_uri_with_tag_filter $cache_repo "staging" | jq -e " |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
In order to validate git fetch --tags we need to use a cached repo with the source not updated in order to have a diff between the tag replaced. Signed-off-by: talset <talset55@gmail.com>
awesome, thanks a bunch! |
issue: #233
Update git fetch with
-f
ensure local refs are always the same as the upstream