Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[check] Allow triggering with tag updates #223

Merged
merged 6 commits into from
Dec 11, 2018
Merged

[check] Allow triggering with tag updates #223

merged 6 commits into from
Dec 11, 2018

Commits on Dec 4, 2018

  1. fix $tag_filter condition to -n

    $tag_filter is a variable not a directory. The check should be -n not
    -d.
    talset committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    deb26d8 View commit details
    Browse the repository at this point in the history
  2. check: Return commit from the tag as resource version

    Current git resource is only watch tags name but not tags update. So
    pipelines aren't triggered when the tag is updated and the resource
    
    with `error: pathspec 'DEV' did not match any file(s) known to git.`
    To solve it I suggest to not use only ref but ref and commit when
    tag_filter is used.
    This commit allow to store the tag name and commit id associeted to
    
    tag as "version" of the resource. With thos way we are able to
    re-trigger the pipeline when a the tags is updated.
    talset committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    baa1672 View commit details
    Browse the repository at this point in the history
  3. test/helpers.sh: git tag -f

    Add --force option on git tag in order to be able to update existing
    tag.
    It help to test the filter_tags code by validating a changes on the
    tag commit.
    talset committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    2e8611b View commit details
    Browse the repository at this point in the history
  4. in: always use --single-branch on clone

    When no branch are specified it clone master. We dont need to get all
    branches, so we can use --single-branch as previously even if no branch
    are specified.
    talset committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    e158784 View commit details
    Browse the repository at this point in the history
  5. check: fix an extra --list from git tag

    --list is only required once
    talset committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    325f186 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. assets/check: use jq for get_commit and minor vars

    Suggested by vito: use jq just in case someone has funny tag names.
    Use lowercase variables
    talset committed Dec 11, 2018
    Configuration menu
    Copy the full SHA
    4212b5e View commit details
    Browse the repository at this point in the history