Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a full clone when tag filter is set and branch is not #176

Conversation

regisbelson
Copy link

@regisbelson regisbelson commented Feb 28, 2018

I tought I was opening this against my own fork but... let's do this anyway.
Tag filtering is quite useful but being limited to the tracked branch isn't suitable for all workflows. In our team, we tag commits from other branches and expect to be able to build/deploy these tags if we want to.
Cloning with --single-branch prevents that. Since you can't know if the commit exists in a given branch before cloning the repository, just clone everything when there are tags involved unless you explicitly specified a branch to track.

@pivotal-issuemaster
Copy link

@kurlzor Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@regisbelson regisbelson force-pushed the do-a-full-clone-when-tag-filter-is-set branch from 9bc03e3 to af15567 Compare February 28, 2018 15:59
@regisbelson regisbelson changed the title Do a full clone when tag filter is set Do a full clone when tag filter is set and branch is not Feb 28, 2018
@pivotal-issuemaster
Copy link

@kurlzor Thank you for signing the Contributor License Agreement!

@regisbelson regisbelson force-pushed the do-a-full-clone-when-tag-filter-is-set branch from af15567 to f7a3a30 Compare February 28, 2018 16:47
@r-chris
Copy link

r-chris commented Mar 14, 2018

I was about to do a similar thing. You @kurlzor probably need to update the documentation as well. Right now the branch documentation talks about it defaulting to the master.

@vito
Copy link
Member

vito commented Apr 11, 2018

This was previously attempted in #165 which ended up with a fairly complicated discussion. I'm not sure the proposed changes are enough.

To be honest, I don't think we should have pulled in the tag_filter behavior, and that should really just be a different resource. The semantics are entirely different. This may be something we consider during the migration to the new resource interface that we're planning in concourse/rfcs#1.

@vito
Copy link
Member

vito commented May 28, 2018

Hmm, I think this should maybe just be closed for now (because #165 showed that things are a bit more complicated), and we should revisit tag_filter in the future. It may make more sense to have support for tags across all branches as another way to support spaces (concourse/concourse#1707), either with this resource type or a more tag-focused one.

Thanks for PRing this though!

@vito vito closed this May 28, 2018
@regisbelson regisbelson deleted the do-a-full-clone-when-tag-filter-is-set branch May 28, 2018 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants