Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix team_name overwritten bug #8566

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Fix team_name overwritten bug #8566

merged 1 commit into from
Oct 4, 2022

Conversation

xtremerui
Copy link
Contributor

@xtremerui xtremerui commented Sep 20, 2022 •
edited
Loading

Notes to reviewer

one test has been added to make sure the patch works. For all other places since the code is same IMO it is not neccessary to duplicate the test.

  • done
  • todo

Release Note

  • Patch a security bug that certain APIs might allow user from a different team to manipulate API resources that belong to another team.

fix team_name overwritten bug
e7a863a 
Signed-off-by: Rui Yang <ruiya@vmware.com>
@xtremerui xtremerui added the bug label Sep 20, 2022
@xtremerui xtremerui added this to the v7.9.0 milestone Sep 20, 2022
@xtremerui xtremerui requested a review from a team as a code owner September 20, 2022 20:56
@xtremerui xtremerui requested a review from syslxg October 3, 2022 18:21
@xtremerui xtremerui mentioned this pull request Oct 4, 2022
Merged
@syslxg syslxg merged commit f72eb75 into master Oct 4, 2022
@syslxg syslxg deleted the fix-team-name-overwritten-api branch October 4, 2022 21:16
@xtremerui xtremerui mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syslxg syslxg syslxg approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v7.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xtremerui @syslxg