Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

187314816 collection corruption #34

Merged
merged 7 commits into from
Apr 10, 2024
Merged

187314816 collection corruption #34

merged 7 commits into from
Apr 10, 2024

Conversation

eireland
Copy link
Contributor

@eireland eireland commented Apr 5, 2024

Fixes bugs when moving attributes around that creates or destroys collections

  • Fixed bug when dropping attribute between levels and attribute moves to top level.
  • Fixed crash when dropping attribute from higher level to lower level.
  • Fixed bug when moving an attribute from between levels to parent level.
  • Fix bug when moving an attribute from a collection with more than one attribute and the collection is named for the attribute being moved, new collection is not made.

@eireland eireland marked this pull request as ready for review April 9, 2024 16:57
lublagg
lublagg approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@lublagg lublagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@eireland eireland merged commit 252fc27 into main Apr 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lublagg lublagg lublagg approved these changes

@dougmartin dougmartin Awaiting requested review from dougmartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eireland @lublagg