Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve v2 types for plot models #1803

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kswenson
Copy link
Member

@kswenson kswenson commented Feb 12, 2025

There are no runtime changes associated with this PR, as the changes are primarily restricted to TypeScript types and comments:

  • clarify/eliminate some v2 import/export TODO comments
  • stricter typing of v2 plot types to assist future implementation

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (353d70d) to head (b253710).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1803      +/-   ##
==========================================
- Coverage   85.84%   85.77%   -0.08%     
==========================================
  Files         636      636              
  Lines       32713    32718       +5     
  Branches     8561     8566       +5     
==========================================
- Hits        28082    28063      -19     
- Misses       4475     4499      +24     
  Partials      156      156              
Flag Coverage Δ
cypress 73.22% <90.90%> (-0.10%) ⬇️
jest 55.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 12, 2025

codap-v3    Run #6283

Run Properties:  status check passed Passed #6283  •  git commit b253710478: chore: improve v2 types for plot models
Project codap-v3
Branch Review 188616847-v2-plot-types
Run status status check passed Passed #6283
Run duration 06m 17s
Commit git commit b253710478: chore: improve v2 types for plot models
Committer Kirk Swenson
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 53
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 242
View all changes introduced in this branch ↗︎

@kswenson kswenson marked this pull request as ready for review February 12, 2025 01:10
@kswenson kswenson requested a review from bfinzer February 12, 2025 01:10
Copy link
Contributor

@bfinzer bfinzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants