Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MixOutlinedBorder #487

Merged
merged 4 commits into from
Sep 25, 2024
Merged

feat: Add MixOutlinedBorder #487

merged 4 commits into from
Sep 25, 2024

Conversation

tilucasoli
Copy link
Collaborator

@tilucasoli tilucasoli commented Sep 20, 2024

Description

  • This PR allows the creation of a custom OutlinedBorder, which can be passed to your component through the Mix API

Changes

  • OutlinedBorderDto become an abstract class
  • Add a method call to ShapeBorderUtility
  • Add the abstract class CustomOutlinedBorder

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Additional Information (optional)

To create your custom OutlinedBorder, you should create a Dto for your border, look at the example:

@MixableDto()
final class MyCustomBorderDto extends OutlinedBorderDto<MyCustomBorder>
    with _$MyCustomBorderDto {
  const MyCustomBorderDto({
    // ... The params
  });
}

To complete the creation, you need to create and define your Border, extending the CustomOutlinedBorder

class MyCustomBorder extends CustomOutlinedBorder<MyCustomBorderDto> {
// implement the border...
}

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 6:25pm

@tilucasoli tilucasoli changed the title extendable border feat: Add CustomOutlinedBorder's Sep 23, 2024
@tilucasoli tilucasoli force-pushed the wip/extendable-border branch from 698fc09 to 6efcf34 Compare September 23, 2024 15:46
This reverts commit 6efcf34.

create custom_border

extendable border

fix border
@github-actions github-actions bot removed the examples label Sep 23, 2024
@tilucasoli tilucasoli force-pushed the wip/extendable-border branch from be8b0b4 to 571d46b Compare September 23, 2024 15:47
@tilucasoli tilucasoli marked this pull request as ready for review September 23, 2024 15:48
@tilucasoli tilucasoli merged commit 721a447 into main Sep 25, 2024
6 checks passed
@tilucasoli tilucasoli deleted the wip/extendable-border branch September 25, 2024 19:52
@tilucasoli tilucasoli changed the title feat: Add CustomOutlinedBorder's feat: Add MixOutlinedBorder's Sep 25, 2024
@tilucasoli tilucasoli changed the title feat: Add MixOutlinedBorder's feat: Add MixOutlinedBorder Sep 25, 2024
@github-actions github-actions bot removed the mix label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant