Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add group feature to Radio #435

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

tilucasoli
Copy link
Collaborator

Description

Radio can now be used in groups

Changes

  • This PR adds a new property called groupValue;
  • The RxRadio receives a generic.

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mix-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 3:16pm

@github-actions github-actions bot added the remix label Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

DCM report

✅ no issues found!

Full report: https://github.com/conceptadev/mix/runs/29003082144

@tilucasoli tilucasoli force-pushed the feat/group-feature-to-radio branch from 0c33b4e to bdd830d Compare August 21, 2024 20:52
@tilucasoli tilucasoli requested a review from leoafarias August 21, 2024 20:53
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tilucasoli tilucasoli merged commit 2829b73 into main Aug 22, 2024
6 checks passed
@tilucasoli tilucasoli deleted the feat/group-feature-to-radio branch August 22, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants