fix: nullable merge expressions and updates debug properties #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
leoafarias
changed the title
tilucasoli
added
mix
mix_generator
remix
repo
mix_annotations
and removed
mix
mix_generator
repo
remix
labels
DCM report✅ no issues found! Full report: https://github.com/conceptadev/mix/runs/27816723848 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Yeah, it fixes issue 390
Description
Sometimes the generator would forget to add ?. when an expression can evaluate to null, so now it appends nullable all the time. I don't know what the performance considerations are of this, but it works.
And when registrering the debug properties the old way was outdated.
Changes
Review Checklist