Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement quick fix for mix_attributes_ordering rule #381

Merged
merged 2 commits into from
Jul 18, 2024
Merged

feat: implement quick fix for mix_attributes_ordering rule #381

merged 2 commits into from
Jul 18, 2024

Conversation

tilucasoli
Copy link
Collaborator

@tilucasoli tilucasoli commented Jul 16, 2024 •
edited
Loading

Related issue

closes #382

Description

  • Create a quick fix to the mix_attributes_ordering rule

Changes

  • Add a Fix to the mix_attributes_ordering rule
  • Create tests
  • Bring golden test to the project

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

@vercel Vercel
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Jul 16, 2024 8:57pm

@tilucasoli tilucasoli changed the title feat: quick fix to the mix_attributes_ordering rule feat: implement quick fix for mix_attributes_ordering rule Jul 16, 2024
@tilucasoli tilucasoli requested a review from leoafarias July 16, 2024 21:10
leoafarias
leoafarias approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit 8f9f655 into main Jul 18, 2024
8 checks passed
@leoafarias leoafarias deleted the feat/auto-fix-attribute-order branch July 18, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoafarias leoafarias leoafarias approved these changes

Assignees
No one assigned
Labels
mix_lint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement quick fix for mix_attributes_ordering rule
2 participants
@tilucasoli @leoafarias