Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gap resolve in flex attribute #327

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Conversation

tilucasoli
Copy link
Collaborator

@tilucasoli tilucasoli commented Jun 26, 2024

Related issue

#326

Description

FlexSpecAttribute didn't resolve correctly when using tokens.

Changes

  • Create GapDto, GapUtility
  • Change the Dto used in FlexSpecAttribute

Review Checklist

  • Testing: Have you tested your changes, including unit tests and integration tests for affected code?
  • Breaking Changes: Does this change introduce breaking changes affecting existing code or users?
  • Documentation Updates: Are all relevant documentation files (e.g. README, API docs) updated to reflect the changes in this PR?
  • Website Updates: Is the website containing the updates you make on documentation?

Impacted Packages

Please indicate which packages in our project are affected by these changes:

  • mix
  • mix_lint
  • mix_generator
  • documentation

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
mix-docs ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 6:23pm

@tilucasoli tilucasoli requested a review from leoafarias June 26, 2024 14:53
Copy link
Contributor

github-actions bot commented Jun 26, 2024

DCM report

✅ no issues found!

Full report: https://github.com/conceptadev/mix/runs/26713918230

@tilucasoli tilucasoli force-pushed the fix/flex-attribute-resolve-gap branch from 96736aa to 10ad2c5 Compare June 27, 2024 15:48
Copy link
Member

@leoafarias leoafarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoafarias leoafarias merged commit 87bf939 into main Jun 27, 2024
4 checks passed
@leoafarias leoafarias deleted the fix/flex-attribute-resolve-gap branch June 27, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants