tools.collect_libs now use self.cpp_info.libdirs #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jgsogo
reviewed
Sep 24, 2018
reference/tools.rst
Outdated
| self.cpp_info.libs = tools.collect_libs(self) | ||
|
|
||
| For UNIX libraries staring with **lib**, like *libmath.a*, this tool will collect the library name **math**. | ||
|
|
||
| **Parameters:** | ||
| - **conanfile** (Required): A `ConanFile` object from which to get the `package_folder`. | ||
| - **folder** (Optional, Defaulted to ``"lib"``): The subfolder where the library files are. | ||
| - **conanfile** (Required): A `ConanFile` object to get the `package_folder` and ``cpp_info``. |
There was a problem hiding this comment.
ConanFile and package_folder should go with double quotes, shouldn't they?
|
This PR is the documentation for this one (conan-io/conan#3503), right? |
|
Yes, it is linked in the issue indicated in the description. |
|
Change-log not needed anymore. And code PR was already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #836