Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ConanInvalidConfiguration, fix some indentation issues #820

Merged
merged 4 commits into from
Sep 25, 2018

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Sep 13, 2018

Documentation for conan-io/conan#3517

@danimtb
Copy link
Member

danimtb commented Sep 13, 2018

I think this worths a mention in the configure() method from reference:
https://docs.conan.io/en/latest/reference/conanfile/methods.html#configure-config-options

Please explain explicitly there that the configure() should be used to raise when there is a configuration not supported and illustrate it with an example.

@danimtb
Copy link
Member

danimtb commented Sep 13, 2018

Missing changelog.

Will probably conflict with #821. Let's see which one is merged first ⚔️

@jgsogo jgsogo added this to the 1.8 milestone Sep 19, 2018
@lasote lasote merged commit e5da3c1 into conan-io:develop Sep 25, 2018
@ghost ghost removed the in review label Sep 25, 2018
@lasote
Copy link
Contributor

lasote commented Sep 25, 2018

@danimtb you lose

@jgsogo jgsogo deleted the pr/3517 branch September 25, 2018 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants