Fix replace requires for zlib in profile #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
memsharded
reviewed
Jun 6, 2024
reference/config_files/profiles.rst
Outdated
| @@ -36,7 +36,7 @@ They have this structure: | |||
| tools.build:jobs=2 | |||
|
|
|||
| [replace_requires] | |||
| zlib/1.2.123: zlib/* | |||
| zlib/1.2.123: zlib/[*] | |||
There was a problem hiding this comment.
The previous syntax is supported, and it means to replace the existing version with the same version, as a place holder, but needs to be something like zlib/*: zlib-ng/*, which is different than replacing something by a version range.
There was a problem hiding this comment.
Suggested change
| zlib/1.2.123: zlib/[*] | |
| zlib/1.2.12: zlib/[*] |
There was a problem hiding this comment.
The previous syntax is supported, and it means to replace the existing version with the same version, as a place holder, but needs to be something like zlib/: zlib-ng/
Yes, but zlib/*: zlib-ng/* is documented already in https://docs.conan.io/2/reference/config_files/profiles.html#replace-requires. Nice to know, thank you.
memsharded
approved these changes
Jun 6, 2024
AbrilRBS
approved these changes
Jun 6, 2024
reference/config_files/profiles.rst
Outdated
| @@ -36,7 +36,7 @@ They have this structure: | |||
| tools.build:jobs=2 | |||
|
|
|||
| [replace_requires] | |||
| zlib/1.2.123: zlib/* | |||
| zlib/1.2.123: zlib/[*] | |||
There was a problem hiding this comment.
Suggested change
| zlib/1.2.123: zlib/[*] | |
| zlib/1.2.12: zlib/[*] |
Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual replace-requires usage in the profile shows
zlib/1.2.123: zlib/*, which does not work. My guess is "replace zlib/1.2.123 by latest version available", but then we need to use[*]instead.Related to the PR #3495
/cc @RubenRBS