Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment information to CMakePresets docs #3488

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Dec 18, 2023

@czoido czoido added this to the 2.0.15 milestone Dec 18, 2023
@czoido czoido marked this pull request as draft December 18, 2023 13:40
@czoido czoido marked this pull request as ready for review December 18, 2023 13:50
@@ -504,6 +523,7 @@ CMakeToolchain is affected by these ``[conf]`` variables:
- **tools.cmake.cmaketoolchain:system_processor** is not necessary in most cases and is only used to force-define ``CMAKE_SYSTEM_PROCESSOR``.
- **tools.cmake.cmaketoolchain:toolset_arch**: Will add the ``,host=xxx`` specifier in the ``CMAKE_GENERATOR_TOOLSET`` variable of ``conan_toolchain.cmake`` file.
- **tools.cmake.cmake_layout:build_folder_vars**: Settings and Options that will produce a different build folder and different CMake presets names.
- **tools.cmake.cmaketoolchain:presets_environment**: Set to ``'disable'`` to prevent the addition of the environment section to the generated CMake presets.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable or disabled?

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good for now, to see how it goes, if it works well, etc.
But later, I think we want:

  • to integrate a bit more in the tutorial, maybe remove some examples call to conanbuild.bat|sh that could be resolved by this feature
  • Define a full example that shows how this is used, and doesn't require calling conanbuild/conanrun scripts

@memsharded memsharded merged commit edd9660 into conan-io:develop2 Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants