Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for qbs build helper and qbs toolchain #1978

Merged
merged 22 commits into from
Jan 19, 2021
Merged

Add documentation for qbs build helper and qbs toolchain #1978

merged 22 commits into from
Jan 19, 2021

Conversation

Psy-Kai
Copy link
Contributor

@Psy-Kai Psy-Kai commented Jan 11, 2021

Documentation for conan-io/conan#8125

@czoido czoido added this to the 1.33 milestone Jan 12, 2021
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but ready to go!

creating_packages/toolchains/qbs.rst Outdated Show resolved Hide resolved
creating_packages/toolchains/qbs.rst Outdated Show resolved Hide resolved
creating_packages/toolchains/qbs.rst Outdated Show resolved Hide resolved
creating_packages/toolchains/qbs.rst Outdated Show resolved Hide resolved
creating_packages/toolchains/qbs.rst Outdated Show resolved Hide resolved
creating_packages/toolchains/qbs.rst Outdated Show resolved Hide resolved
creating_packages/toolchains/qbs.rst Outdated Show resolved Hide resolved
creating_packages/toolchains/qbs.rst Outdated Show resolved Hide resolved
reference/build_helpers/qbs.rst Outdated Show resolved Hide resolved
reference/build_helpers/qbs.rst Outdated Show resolved Hide resolved
reference/build_helpers/qbs.rst Outdated Show resolved Hide resolved
creating_packages/toolchains/qbs.rst Outdated Show resolved Hide resolved
@danimtb danimtb merged commit 73c22bd into conan-io:develop Jan 19, 2021
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The location of this is wrong, I am moving things to reference -> conan.tools.qbs, that is the new home for the new tools. I will do a new PR with it.


.. code-block:: python

from conans import ConanFile, tools, Qbs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import is wrong, the right one is from conan.tools.qbs import Qbs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants