Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for cmake_multi generator #1121

Merged
merged 7 commits into from
Mar 27, 2019
Merged

Docs for cmake_multi generator #1121

merged 7 commits into from
Mar 27, 2019

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Mar 15, 2019

Docs for issue conan-io/conan#2820 and PR conan-io/conan#4721

Built on top of #1120

⚠️ This PR should be reviewed and merged after #1120 is merged to master and develop branch is updated with its changes ⚠️

@ghost ghost assigned danimtb Mar 15, 2019
@ghost ghost added the stage: review label Mar 15, 2019
@danimtb danimtb added this to the 1.14 milestone Mar 15, 2019
@danimtb danimtb removed their assignment Mar 15, 2019
@danimtb danimtb changed the title Feature/conan/2820 Docs for cmake_multi generator Mar 15, 2019
@ghost ghost assigned danimtb Mar 15, 2019
jgsogo
jgsogo reviewed Mar 18, 2019
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a preliminar review, I'll come back once the depending PR is merged.

reference/generators/cmakemulti.rst

Macros available in *conanbuildinfo_multi.cmake*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would focus on the differences between cmake and cmake_multi. This piece of docs is not going to be complete (above you have already referenced to "same as conanbuildinfo.cmake with suffix _DEBUG"), so I think it makes no sense to have here almost the copy/paste.

Maybe we have to document here how this file includes debug/release one, and those more generic variables and macros...

@danimtb danimtb mentioned this pull request Mar 26, 2019
Merged
5 tasks
@danimtb danimtb requested a review from jgsogo March 26, 2019 16:40
@danimtb danimtb removed their assignment Mar 26, 2019
@danimtb
Copy link
Member Author

danimtb commented Mar 27, 2019

Please take a look at this so it can be moved forward as the code PR was already merged

jgsogo
jgsogo approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better docs, better software! 🎉

@jgsogo jgsogo merged commit 68779c7 into conan-io:develop Mar 27, 2019
@ghost ghost removed the stage: review label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@jgsogo jgsogo jgsogo approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
3 participants
@danimtb @jgsogo @memsharded