Skip to content

Commit

Permalink
Don't advocate use of pgk* in unified patterns. (#3032)
Browse files Browse the repository at this point in the history
There are libraries with a common prefix that might introduce
ambiguities now or later, e.g. zlib and zlib-ng.
Prefer using `pkg/*` over `pkg*` which is more explicit.

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
  • Loading branch information
oxygene and czoido authored Feb 28, 2023
1 parent 000f2f2 commit d61ba28
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions migrating_to_2.0/commands.rst
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ There are some examples:
.. code-block:: shell
:caption: **To:**
conan install . --build zlib*
conan install . --build zlib/*
conan install . --build zlib/1.2.11
conan install . --build zlib/1.*
Expand All @@ -133,7 +133,7 @@ There are some examples:
.. code-block:: shell
:caption: **To:**
conan install . -s zlib*:arch=x86 -o zlib*:shared=True
conan install . -s zlib/*:arch=x86 -o zlib/*:shared=True
conan install . -s zlib/1.2.11@user/channel:arch=x86 -o zlib/1.2.11:shared=True
Commands with have been removed
Expand Down
2 changes: 1 addition & 1 deletion migrating_to_2.0/recipes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ The definition of the ``default_options`` attribute has changed when referring t
from conan import ConanFile
class Pkg(Conanfile):
# "pkg/*:some_option" or ""pkg/1.0:some_option" or "pkg*:some_option" would be valid
# "pkg/*:some_option" or ""pkg/1.0:some_option" would be valid
default_options = {"pkg/*:some_option": "value"}
Expand Down

0 comments on commit d61ba28

Please sign in to comment.