Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8499
continues story in #8113
it turns out the function
_detect_os_arch
(part of thedetect_defaults_settings
) didn't usedetected_architecture
and used its own mapping.I guess it's better to have changes unified, done within a single place, so it's harder to forget to update both functions (like in the case of M1).
another confusing thing was:
which emitted the error event after
arm64
was added to the settings.yml. I also corrected that, so the function always loads the settings. (to be honest, I am not even sure the error message is needed at all, as it doesn't play nice with custom settings).Changelog: BugFix: Fix Apple M1 detection.
Docs: omit
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.