Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added connection message error to output #685

Merged
merged 1 commit into from
Nov 24, 2016

Conversation

memsharded
Copy link
Member

To solve: #682

@lasote lasote merged commit 7d6c026 into conan-io:develop Nov 24, 2016
memsharded added a commit to memsharded/conan that referenced this pull request Nov 30, 2016
SSE4 added a commit to SSE4/conan that referenced this pull request Jan 24, 2017
Signed-off-by: SSE4 <tomskside@gmail.com>
memsharded pushed a commit that referenced this pull request Jan 24, 2017
Signed-off-by: SSE4 <tomskside@gmail.com>
@memsharded memsharded deleted the feature/connection_error_msg branch March 9, 2017 09:58
memsharded pushed a commit that referenced this pull request Aug 25, 2017
* #685 remove trailing slash from the remote URL

Signed-off-by: SSE4 <tomskside@gmail.com>

* - use wswhere to locate Visual Studio, when available

* - set VSCMD_START_DIR because vcvarsall.bat changes current directory which may be undesired

* - extract vs_installation_path method and cache its value to avoid excessive executing of vswhere

* - remove trailing slash

* - keys() is unnecessary when checking dicts containment

* - vs_installation_path handles error itself
lasote pushed a commit that referenced this pull request Aug 28, 2017
* #685 remove trailing slash from the remote URL

Signed-off-by: SSE4 <tomskside@gmail.com>

* - use wswhere to locate Visual Studio, when available

* - set VSCMD_START_DIR because vcvarsall.bat changes current directory which may be undesired

* - extract vs_installation_path method and cache its value to avoid excessive executing of vswhere

* - remove trailing slash

* - keys() is unnecessary when checking dicts containment

* - vs_installation_path handles error itself

* detect, some style and refactors

* using sys.stdout.encoding breaks for piped cmds

* removed unwanted file

* merged with develop
lasote pushed a commit that referenced this pull request Sep 8, 2017
* #685 remove trailing slash from the remote URL

Signed-off-by: SSE4 <tomskside@gmail.com>

* - filter out non-existing and empty directories

* fixed tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants