Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 6483 do not download binary for conan info #6487

Closed
wants to merge 7 commits into from
Closed

Fix 6483 do not download binary for conan info #6487

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6018971
Added: Unittest for casing
monsdar Mar 25, 2019
8fe2f73
Added: Case-sensitive checking
monsdar Mar 26, 2019
899b8f2
Merge branch 'develop' of https://github.com/conan-io/conan into develop
Sep 13, 2019
d9a6607
Merge branch 'develop' of https://github.com/monsdar/conan into develop
monsdar Jan 30, 2020
91cf2dc
Merge branch 'develop' of https://github.com/conan-io/conan into develop
monsdar Jan 30, 2020
27acc89
Merge branch 'develop' of https://github.com/conan-io/conan into develop
monsdar Feb 6, 2020
fbf2d4a
Changed: Now only downloading the binaries from remotes when user exp…
monsdar Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions conans/client/graph/graph_binaries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ def _evaluate_cache_pkg(self, node, package_layout, pref, metadata, remote, remo

def _evaluate_remote_pkg(self, node, pref, remote, remotes):
remote_info = None
if remote:
if remotes.selected:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking most of the binary-remote logic in Conan.

If no remote is explicitly selected, the location of the binary package is:

  • The one defined from the binary package, if it was previously downloaded
  • The one defined for the recipe, if the recipe is associated with a remote.

As you can see in the CI, a ton of tests are broken by this.

We need to understand better:

  • If this is a regression, it seems it is not, the behavior has always been there
  • I'd say that the binary is not really downloaded, but the server is actually queried for the information of it. That is what the conan info command does. The title might be a bit misleading.
  • Disabling all remotes indeed should completely avoid contacting them, if true, that could be a bug, but not related to the remotes.selected specification of remote.

try:
remote_info, pref = self._remote_manager.get_package_info(pref, remote)
remote_info, pref = self._remote_manager.get_package_info(pref, remotes.selected)
except NotFoundException:
pass
except Exception:
Expand Down