Handling error when reference not found using conan download #5399
Conversation
a reference that is not in the remote
conans/client/conan_api.py
Outdated
| @@ -74,6 +74,13 @@ def wrapper(*args, **kwargs): | |||
| with tools.environment_append(api._cache.config.env_vars): | |||
| # Patch the globals in tools | |||
| return f(*args, **kwargs) | |||
| except NotFoundException as exc: | |||
There was a problem hiding this comment.
Hi @czoido
I don't think this should be handled here, but much sooner. Here it is too late, and there are other things that could cause a NotFoundException (e.g. trying to download a .zip for the conan config install).
It is the exception itself who should encode a better error message as close to the raise as possible, by the one that has the context (remote_name, ref, or whatever makes sense)
conans/client/cmd/download.py
Outdated
| try: | ||
| ref = remote_manager.get_recipe(ref, remote) | ||
| except NotFoundException as exc: | ||
| if exc.args and "404" in exc.args[0]: |
There was a problem hiding this comment.
You can skip the check of 404, you already got that exception. It is ok to re-raise it with a new message.
|
Check the broken test: https://conan-ci.jfrog.info/blue/organizations/jenkins/ConanTestSuite/detail/PR-5399/3/pipeline Also, consider adding a new test or a new check in existing test for the |
|
Great, thanks! |
Changelog: Fix: Handling error when reference not found using conan download
Docs: Omit
Fixes: #5397
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.