-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old folder for conan install (#5376) #5384
Remove old folder for conan install (#5376) #5384
Conversation
- Use current time as folder suffix Signed-off-by: Uilian Ries <uilianries@gmail.com>
- Replace current time by UUID. Signed-off-by: Uilian Ries <uilianries@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to remove the folder at the beginning if it exists to avoid creating N dirty folders.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the test can be easier now. Just write a file after the first call and check after the second that the file is not there anymore.
conans/test/unittests/client/conf/config_installer/test_install_folder.py
Show resolved
Hide resolved
conans/test/unittests/client/conf/config_installer/test_install_folder.py
Outdated
Show resolved
Hide resolved
And please, @uilianries , change the changelog according to the behavior. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@jgsogo done! |
Changelog: Fix: Remove old folder for conan install (#5376)
Docs: Omit
fixes #5376
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.